Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ember.Map, Ember.MapWithDefault and Ember.OrderedSet #237

Merged
merged 4 commits into from Apr 6, 2018

Conversation

@Serabe
Copy link
Member

commented Jul 20, 2017

rendered


# Transition Path

The classes will be extracted to an addon and the ones in Ember will be deprecated.

This comment has been minimized.

Copy link
@stefanpenner

stefanpenner Jul 20, 2017

Member

what are the details on how ember-data will work, and how we can be backwards compat with ED. It's possible, but that needs to be fleshed out in this RFV

This comment has been minimized.

Copy link
@buschtoens

buschtoens Jul 26, 2017

If that is in the scope of this RFC, it might be worthwhile to take a look at switching to the native ES6 Map. The MapWithDefault behavior can be easily achieved: Babel REPL PoC

I would be available for such a PR in Ember Data. 🙋‍♂️

This comment has been minimized.

Copy link
@locks

locks Jul 26, 2017

Contributor

@buschtoens I don't think it is. Switching to native Map seems like a big undertaking, especially if we are to support IE9 and family :P


# Drawbacks

This requires cooperation with Ember Data, the main user of these classes. It would be nice to have moved Ember Data to using the addon before releasing Ember with the deprecation so the average user does not see any deprecation warning.

This comment has been minimized.

Copy link
@jrjohnson

jrjohnson Jul 26, 2017

👍 for this option. I recall the last time something in heavy use in Ember Data was deprecated I was hit with a terrifying number of notices that I could do nothing about. While methods now exist to hep with this it should still be avoided if possible.

@locks locks changed the title Remove Ember.Map, Ember.MapWithDefault and Ember.OrderedSet RFC Remove Ember.Map, Ember.MapWithDefault and Ember.OrderedSet Jul 31, 2017

@locks locks added this to In Progress in Deprecation Candidates Jan 18, 2018

@rwjblue

This comment has been minimized.

Copy link
Member

commented Mar 2, 2018

I'd like to see this one start to gain traction now that 3.0 is "out the door".

@Serabe - Thanks for the recent round of updates! I think the task list in the transition path looks pretty close to what I was thinking, but I'd like to make it clearer that the deprecation would only be landed once a released version of ember-data that included the fixes (to prevent the deprecation) shipped. Do you think that is clear enough in the current prose?

@rwjblue

This comment has been minimized.

Copy link
Member

commented Mar 7, 2018

Changes landed in ember-data to remove direct usage of these classes:

  • emberjs/data#5372 - Migrates ember-data to use the @ember/ordered-set addon (instead of relying on Ember.OrderedSet)
  • emberjs/data#5255 - Migrates to using native Map, and removes any Ember Data usage of Ember.Map or Ember.MapWithDefault.

Both of those PR's should wind up included in ember-data@3.1.

@rwjblue

This comment has been minimized.

Copy link
Member

commented Mar 9, 2018

Just discussed this with the rest of the core team, and with the recent round of changes and the work in ember-data to detangle from these classes we think this is ready for final comment period.

addressed concerns

@kennethlarsen kennethlarsen referenced this pull request Mar 26, 2018

Merged

Ember 3.1 Release Blog Post #3230

1 of 13 tasks complete

@rwjblue rwjblue merged commit 1a735bf into emberjs:master Apr 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Deprecation Candidates automation moved this from In Progress to Finished Apr 6, 2018

@rwjblue

This comment has been minimized.

Copy link
Member

commented Apr 6, 2018

Lets do it!

@locks locks deleted the Serabe:deprecate-ember-map branch Apr 14, 2018

@rwjblue rwjblue referenced this pull request Jun 1, 2018

Closed

Ember 3.2 Release Blog Post #3350

0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.