Repository navigation
RFC: toggle-visibility - #26
Closed
jamesarosen wants to merge 1 commit into
Closed
jamesarosen wants to merge 1 commit into
jamesarosen wants to merge 1 commit into
Conversation
Member
|
|
Author
|
Related Twitter thread: https://twitter.com/paul_irish/status/564577651609059329 Could be obviated by jquery/jquery#2057 |
Author
|
emberjs/ember.js#9634 has some more information, including some points on accessibility. |
Author
There was a problem hiding this comment.
I would prefer alternative 2, but I have two reservations:
- is it OK for Ember to inject
<style>[hidden] { display: none; }</style>into the page on boot? Is that likely to break apps? Could it at least inject it before any other<link>or<style>tags so it's easy to override with simple CSS? - are there apps or addons that rely on
el.prop('style').displaybeing"none"for hidden views? (As opposed to them just not being visible.)
Member
|
We are trying to pare down the number of built-in APIs that abstract DOM features. In favor of this, we'd recommend people use an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered