Skip to content

Deprecate disabledWhen of link-to component - #267

Closed
bekzod wants to merge 5 commits into
emberjs:masterfrom
bekzod:deprecate-disabled-when
Closed

bekzod wants to merge 5 commits into
emberjs:masterfrom
bekzod:deprecate-disabled-when

Conversation

@bekzod

@bekzod bekzod commented Nov 3, 2017 •

Copy link
Copy Markdown

@bekzod bekzod changed the title RFC: Deprecate link-to / disabledWhen RFC: Deprecate disabledWhen of link-to component Nov 3, 2017
@jamesarosen

Copy link
Copy Markdown

{{link-to}} also has a currentWhen property whose implementation is backed by routing.isActiveForRoute. It would be neat to extract a helper:is-active-for-route so clients can build up more expressive logic for both current and disabled.

@rwjblue

rwjblue commented Nov 8, 2017

Copy link
Copy Markdown
Member

@jamesarosen - I believe that is what ember-router-helpers's is-active helper does...

@bekzod

bekzod commented Apr 25, 2018 •

Copy link
Copy Markdown
Author

@rwjblue can we move this final comment period or merge it ?

@bekzod bekzod changed the title RFC: Deprecate disabledWhen of link-to component Deprecate disabledWhen of link-to component Jun 6, 2018
@locks locks added T-deprecation T-framework RFCs that impact the ember.js library labels Sep 18, 2018
@bertdeblock

Copy link
Copy Markdown
Member

Can we close this since @disabledWhen is now deprecated?

@bekzod bekzod closed this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-deprecation T-framework RFCs that impact the ember.js library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants