Skip to content

[DATA] RecordData Operations - #458

Closed
runspired wants to merge 7 commits into
emberjs:masterfrom
runspired:ember-data-record-data-operations
Closed

[DATA] RecordData Operations#458
runspired wants to merge 7 commits into
emberjs:masterfrom
runspired:ember-data-record-data-operations

Conversation

@runspired

Copy link
Copy Markdown
Contributor

@runspired runspired added the T-ember-data RFCs that impact the ember-data library label Mar 6, 2019

@rwjblue rwjblue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a number of things are still missing from this WIP:

  • explicit list of all operations
  • explicit list of all methods to be deprecated on record data
  • "how do we teach this" section / etc

Comment thread text/0000-ember-data-record-data-operations.md Outdated
Comment thread text/0000-ember-data-record-data-operations.md Outdated
Comment thread text/0000-ember-data-record-data-operations.md Outdated
Comment thread text/0000-ember-data-record-data-operations.md
Comment thread text/0000-ember-data-record-data-operations.md Outdated
@runspired runspired changed the title [WIP] Record Data Operations [WIP DATA] RecordData Operations Mar 7, 2019
@runspired runspired changed the title [WIP DATA] RecordData Operations [DATA] RecordData Operations Mar 12, 2019
@dgeb

dgeb commented Mar 13, 2019

Copy link
Copy Markdown
Member

Let's consider using Orbit's operations, which are very close in signature to the proposal here, in order to maximize compatibility: https://github.com/orbitjs/orbit/blob/master/packages/%40orbit/data/src/operation.ts#L4-L106

@dgeb

dgeb commented Mar 13, 2019

Copy link
Copy Markdown
Member

This proposal seems incomplete without operations that create, update, and remove records as a whole.

@runspired

Copy link
Copy Markdown
Contributor Author

Closing in favor of additional exploration internally in this space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-ember-data RFCs that impact the ember-data library

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants