Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprints Update #477

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@kellyselden
Copy link
Member

commented Apr 17, 2019

Rendered

kellyselden added some commits Apr 17, 2019

@meirish

This comment has been minimized.

Copy link

commented Apr 17, 2019

@kellyselden

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@meirish Can you try again? I updated the link.

@kellyselden kellyselden force-pushed the kellyselden:blueprints-update branch from 06ff613 to 29e60fe Apr 17, 2019

@mehulkar

This comment has been minimized.

Copy link

commented Apr 18, 2019

Awesome! I think this would be fantastic. Personally, I am perpetually confused by the various state files in Ember projects... add to that our own build and CI tools, the top level of a project directory quickly becomes intimidating for new users. I would love to see this go in an existing file or even package.json to avoid Yet Another File. It would also be super important for the file to state if it can be changed by end users or not and what effect it would have, so JSON format (sans comments) would be less than ideal, IMO.

@kellyselden

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2019

@mehulkar I've found via further testing that mixing a file that is tracked by the default ember-cli blueprint (.ember-cli, package.json) and modified by ember-cli-update (to update the blueprint metadata), it gets cumbersome. Both processes try to edit the same file. So in theory, ember-cli could alter the .ember-cli file in a way that conflicts with what you have in yours. This would give you a git conflict, then the updater can't read it anymore because it is in a state of invalid JS. I think this further supports a separate file.

@mehulkar

This comment has been minimized.

Copy link

commented Apr 21, 2019

That makes sense

kellyselden added some commits Apr 22, 2019

@kellyselden

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2019

Added sections about complete vs partial blueprints, saving options, and supporting custom blueprint codemods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.