Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate mouseEnter/Leave Ember events #486

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@simonihmig
Copy link
Contributor

commented Apr 27, 2019

Rendered

@simonihmig simonihmig force-pushed the simonihmig:deprecate-mouseenter branch from b1f575c to 321566e Apr 27, 2019

@simonihmig simonihmig force-pushed the simonihmig:deprecate-mouseenter branch from 321566e to 37ae192 Apr 27, 2019

@simonihmig simonihmig changed the title Deprecate mouseEnter/Leave events in EventDispatcher Deprecate mouseEnter/Leave Ember events Apr 27, 2019

@amyrlam amyrlam referenced this pull request Apr 28, 2019

Merged

The Ember Times No. 96 - May 3rd 2019 #95

7 of 15 tasks complete
@locks
Copy link
Contributor

left a comment

Minor changes :)

Show resolved Hide resolved text/0486-deprecate-mouseenter.md Outdated
Show resolved Hide resolved text/0486-deprecate-mouseenter.md
@rwjblue

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thoughts on also adding mousemove to the list to be deprecated? I realize it doesn't have all of the same issues (since it bubbles), but it definitely has the same negative performance impact.

@rwjblue rwjblue self-assigned this Apr 29, 2019

@rwjblue

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Thanks for putting this together @simonihmig!

@simonihmig

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

Thoughts on also adding mousemove to the list to be deprecated?

Yes, I mentioned this under "Alternatives", and personally would be inclined to also include this!

Here's a profiler view when just moving the mouse over an Ember app:

image

The first two scripting executions (mouseout + mouseover) are for mouseenter/leave support, the third is just the normal event listener for mousemove. All these take just a fraction of a millisecond, though at large scale it looks like this: 😕

image

@amyrlam amyrlam referenced this pull request May 5, 2019

Merged

The Ember Times No. 97 - May 10th 2019 #102

6 of 12 tasks complete
Fix example
Co-Authored-By: Jessica Jordan <jessica.jordan.fe.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.