Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Observers #494

Merged
merged 5 commits into from Jun 20, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

add clarifications

  • Loading branch information...
pzuraq committed Jun 7, 2019
commit 7b4d4181bdae1f7f25ebee51878fb4d2997db311
@@ -113,7 +113,7 @@ convert to async observers, or away from observers entirely.

The name of the feature will be `default-async-observers`. Enabling it will
default all observers to be async, but still allow users to set observers to be
synchronous manually.
synchronous manually. This flag will be enabled by default in Ember Octane.

## How we teach this

@@ -143,6 +143,13 @@ Observers are not discussed in the post-Octane guides, since we don't want to
encourage their use. It may make sense to include a section on them in the
upgrade guide instead.

### Upgrade Guides

We should make a note in the Octane upgrade guides that sync observers are
discouraged and probably not very performant. We should be up front that this
will likely be a performance hit, but that we decided it was worth the benefits
of the change.

## Drawbacks

The biggest potential drawback is in performance. While we haven't been able to
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.