Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DATA] findRecord/peekRecord via Identifier #521

Open
wants to merge 5 commits into
base: master
from

Conversation

@runspired
Copy link
Contributor

commented Jul 29, 2019

runspired added some commits Jul 29, 2019

@rwjblue
Copy link
Member

left a comment

I'd like to see example API's of before/after (e.g. imagine migrating a routes model hook to the new API, what does it look like?) and mention of a deprecation guide (plausibly even authoring the guide inline in this RFC to be copied out into the deprecations app once the RFC is merged).

Show resolved Hide resolved text/0521-find-by-identifier.md Outdated
Show resolved Hide resolved text/0521-find-by-identifier.md
Show resolved Hide resolved text/0521-find-by-identifier.md
@rwjblue

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

We chatted about this in todays ember-data meeting, and had a few take aways:

  • Remove mentions of deprecations
  • Remove changes of the return value based on the input arguments

Is that a good summary @runspired / @igorT / @dgeb / @hjdivad / @HeroicEric?

Show resolved Hide resolved text/0521-find-by-identifier.md Outdated
Show resolved Hide resolved text/0521-find-by-identifier.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.