Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - deprecate default serializers and adapters #522

Open
wants to merge 1 commit into
base: master
from

Conversation

@pete-the-pete
Copy link

commented Jul 30, 2019

Rendered

@pete-the-pete pete-the-pete force-pushed the pete-the-pete:master branch from 311e122 to 5b0ceb7 Jul 30, 2019

@pete-the-pete pete-the-pete force-pushed the pete-the-pete:master branch from 5b0ceb7 to 61606c2 Jul 30, 2019

@runspired runspired self-assigned this Jul 31, 2019

@runspired

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thank you for taking on this RFC!

@pete-the-pete pete-the-pete force-pushed the pete-the-pete:master branch from 61606c2 to 3402058 Aug 1, 2019

@runspired runspired referenced this pull request Aug 1, 2019

Open

[QUEST] 🌲Project Trim 🌲 #6166

0 of 55 tasks complete
@snewcomer
Copy link

left a comment

This is great @pete-the-pete! Let me know how I can help.

Today we have extensive documentation about creating custom serializers, but we will need to update the guides to specify the desired serializer in [app/serializers/application.js](https://guides.emberjs.com/release/models/customizing-serializers/#toc_customizing-serializers)

The deprecation guide app will be updated with examples showing how to
migrate away from relying on the defaults.

This comment has been minimized.

Copy link
@snewcomer

snewcomer Aug 2, 2019

Will this include updates to any blueprints? For example adding a default adapter with ember new?

This comment has been minimized.

Copy link
@pete-the-pete

pete-the-pete Aug 5, 2019

Author

That sounds like a great idea, but I'm not sure when it should be mentioned...the RFC is about deprecation, but I think updating the blueprints for the deprecation guide is a good idea. @runspired what are your thoughts?

This comment has been minimized.

Copy link
@runspired

runspired Aug 14, 2019

Contributor

I think that would be a different RFC if at all

@pete-the-pete pete-the-pete force-pushed the pete-the-pete:master branch from 3402058 to c149720 Aug 14, 2019

@dgeb dgeb changed the title RFC - depcreate default serializers and adapters RFC - deprecate default serializers and adapters Aug 14, 2019

@runspired

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

After discussion we have agreed to FCP but also wish to update the individual deprecation details to include guidance on each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.