RFC - deprecate default serializers and adapters#522
Merged
runspired merged 1 commit intoemberjs:masterfrom Aug 22, 2019
pete-the-pete:master
Merged
RFC - deprecate default serializers and adapters#522runspired merged 1 commit intoemberjs:masterfrom pete-the-pete:master
runspired merged 1 commit intoemberjs:masterfrom
pete-the-pete:master
Conversation
ghost
reviewed
Jul 30, 2019
ghost
reviewed
Jul 30, 2019
runspired
added
T-deprecation
T-ember-data
Contributor
|
Thank you for taking on this RFC! |
hjdivad
reviewed
Jul 31, 2019
65 tasks
snewcomer
reviewed
Aug 2, 2019
Contributor
snewcomer
left a comment
snewcomer
left a comment
There was a problem hiding this comment.
This is great @pete-the-pete! Let me know how I can help.
| Today we have extensive documentation about creating custom serializers, but we will need to update the guides to specify the desired serializer in [app/serializers/application.js](https://guides.emberjs.com/release/models/customizing-serializers/#toc_customizing-serializers) | ||
|
|
||
| The deprecation guide app will be updated with examples showing how to | ||
| migrate away from relying on the defaults. |
Contributor
There was a problem hiding this comment.
Will this include updates to any blueprints? For example adding a default adapter with ember new?
Author
There was a problem hiding this comment.
That sounds like a great idea, but I'm not sure when it should be mentioned...the RFC is about deprecation, but I think updating the blueprints for the deprecation guide is a good idea. @runspired what are your thoughts?
Contributor
There was a problem hiding this comment.
I think that would be a different RFC if at all
dgeb
changed the title
Contributor
|
After discussion we have agreed to FCP but also wish to update the individual deprecation details to include guidance on each. |
This was referenced Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered