Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - deprecate default serializers and adapters #522

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@pete-the-pete
Copy link

@pete-the-pete pete-the-pete commented Jul 30, 2019

Rendered

@runspired
Copy link
Contributor

@runspired runspired commented Jul 31, 2019

Thank you for taking on this RFC!

Loading

text/0000-default-serializers-and-adapters.md Outdated Show resolved Hide resolved
Loading
Copy link
Contributor

@snewcomer snewcomer left a comment

This is great @pete-the-pete! Let me know how I can help.

Loading

Today we have extensive documentation about creating custom serializers, but we will need to update the guides to specify the desired serializer in [app/serializers/application.js](https://guides.emberjs.com/release/models/customizing-serializers/#toc_customizing-serializers)

The deprecation guide app will be updated with examples showing how to
migrate away from relying on the defaults.
Copy link
Contributor

@snewcomer snewcomer Aug 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this include updates to any blueprints? For example adding a default adapter with ember new?

Loading

Copy link
Author

@pete-the-pete pete-the-pete Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a great idea, but I'm not sure when it should be mentioned...the RFC is about deprecation, but I think updating the blueprints for the deprecation guide is a good idea. @runspired what are your thoughts?

Loading

Copy link
Contributor

@runspired runspired Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be a different RFC if at all

Loading

@dgeb dgeb changed the title RFC - depcreate default serializers and adapters RFC - deprecate default serializers and adapters Aug 14, 2019
@runspired
Copy link
Contributor

@runspired runspired commented Aug 14, 2019

After discussion we have agreed to FCP but also wish to update the individual deprecation details to include guidance on each.

Loading

@runspired runspired merged commit 2a23ad5 into emberjs:master Aug 22, 2019
2 checks passed
Loading
rwjblue added a commit that referenced this issue Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants