New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper listing (dashless helpers) #58

Merged
merged 1 commit into from Jun 13, 2015

Conversation

Projects
None yet
4 participants
@mixonic
Member

mixonic commented May 24, 2015

Rendered as HTML

A proposed solution for dashless helpers in 1.13. You should likely read #53 before this.

@mixonic mixonic referenced this pull request May 24, 2015

Merged

Helpers #53

@jamesarosen

This comment has been minimized.

Show comment
Hide comment
@jamesarosen

jamesarosen Jun 5, 2015

One place where this might not work is in component-integration tests. Unless the "boot time discovery" phase is run on constructing a container (rather than during an actual app boot), those integration tests won't be able to find helpers.

jamesarosen commented Jun 5, 2015

One place where this might not work is in component-integration tests. Unless the "boot time discovery" phase is run on constructing a container (rather than during an actual app boot), those integration tests won't be able to find helpers.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Jun 5, 2015

Member

It will not require app boot. Component integration/unit tests are very much assisted by this RFC.

Member

rwjblue commented Jun 5, 2015

It will not require app boot. Component integration/unit tests are very much assisted by this RFC.

@jamesarosen

This comment has been minimized.

Show comment
Hide comment
@jamesarosen

jamesarosen commented Jun 5, 2015

Veronica Mars Over-the-Moon Face

@mixonic mixonic referenced this pull request Jun 8, 2015

Merged

Ember 1.13 and 2.0 support #227

@rwjblue rwjblue referenced this pull request Jun 10, 2015

Merged

[FEATURE ember-htmlbars-dashless-helpers] RFC#58. #11393

2 of 2 tasks complete
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue
Member

rwjblue commented Jun 10, 2015

Implemented in emberjs/ember.js#11393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment