Skip to content

Simplifying Schema Definition Service type signatures - #642

Closed
igorT wants to merge 15 commits into
emberjs:masterfrom
igorT:igor/schema-definiton
Closed

Simplifying Schema Definition Service type signatures#642
igorT wants to merge 15 commits into
emberjs:masterfrom
igorT:igor/schema-definiton

Conversation

@igorT

@igorT igorT commented Jun 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@igorT igorT added the T-ember-data RFCs that impact the ember-data library label Jun 24, 2020
@igorT igorT changed the title Schema Definition Simplification Simplifying Schema Definition Service type signatures Jun 24, 2020
@igorT
igorT force-pushed the igor/schema-definiton branch from bfad487 to 14ab99b Compare June 24, 2020 20:49
@igorT
igorT force-pushed the igor/schema-definiton branch from 14ab99b to 6fd398e Compare June 24, 2020 21:15
sandstrom
sandstrom reviewed Jun 30, 2020
View reviewed changes

@sandstrom sandstrom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea!

Thanks for all your work on Ember Data @igorT 🏅

Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Jul 29, 2020
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Jul 29, 2020
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Jul 30, 2020
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer approved these changes Jul 30, 2020
View reviewed changes

@snewcomer snewcomer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knownasilya

knownasilya commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

Ping

MrChocolatine
MrChocolatine reviewed Jan 18, 2021
View reviewed changes
Comment thread text/0000-template.md Outdated
Comment thread text/0000-template.md Outdated
Comment thread text/0000-template.md Outdated
snewcomer and others added 6 commits February 12, 2022 08:07
@snewcomer @sandstrom
Update text/0000-template.md
c540cd6 
Co-authored-by: sandstrom <mail+github@a16m.se>
@snewcomer
Update text/0000-template.md
ab8d504
@snewcomer MrChocolatine
Update text/0000-template.md
34cf302 
Co-authored-by: MrChocolatine <mz.pro@pm.me>
@snewcomer MrChocolatine
Update text/0000-template.md
34399af 
Co-authored-by: MrChocolatine <mz.pro@pm.me>
@snewcomer MrChocolatine
Update text/0000-template.md
c1395de 
Co-authored-by: MrChocolatine <mz.pro@pm.me>
@snewcomer
Update text/0000-template.md
53f9688
@snewcomer snewcomer mentioned this pull request Feb 12, 2022
Merged
1 task
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
snewcomer
snewcomer reviewed Feb 12, 2022
View reviewed changes
Comment thread text/0000-template.md Outdated
@snewcomer snewcomer mentioned this pull request Feb 12, 2022
Merged
@snewcomer

snewcomer commented Feb 12, 2022

Copy link
Copy Markdown
Contributor

superseded by #794 due to lack of rights to change file name to pass lint.

@snewcomer snewcomer closed this Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@sandstrom sandstrom sandstrom left review comments
@snewcomer snewcomer snewcomer approved these changes
@MrChocolatine MrChocolatine MrChocolatine left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Final Comment Period T-ember-data RFCs that impact the ember-data library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@igorT @knownasilya @snewcomer @sandstrom @MrChocolatine