Deprecate {{hasBlock}} and {{hasBlockParams}} in templates

[pzuraq]

Rendered

[bertdeblock]

👋 Should hasBlockParams be included in this RFC as well or should that be a separate one?

It seems:

{{#if hasBlockParams}}

{{/if}}

and

{{#if (has-block-params)}}

{{/if}}

accomplish the same thing as well.

[chancancode]

Yep let's add hasBlockParams to the RFC as well!

[chancancode]

We discussed this on the framework core team meeting today. We are all 👍 but agreed logistically it's easier to add hasBlockParams to this RFC first.

[pzuraq]

Yeah, the only reason it was not part of this RFC was because the transform only documents that it works for hasBlock 🙃 will add it this week

[ijlee2]

Hi, @pzuraq. Could you update the link for Rendered? I think it's broken cause the RFC title changed of RFC no. Thanks.

[rwjblue]

We discussed this at todays core team meeting, and are moving it into final comment period.

[jelhan]

Both {{has-block}} and {{has-block-params}} are currently documented as hasBlock and hasBlockParams in API docs. This might be very confusing when this deprecation lands.

[jelhan]

Suggested change

	The `{{hasBlockParams}}` property is true if the component was given a default block,
	and false otherwise. To transition away from it, you can use the `(has-block-params)`
	helper instead.
	The `{{hasBlockParams}}` property is true if the component was invoked with block
	params for the default block, and false otherwise. To transition away from it, you can
	use the `(has-block-params)` helper instead.

[rwjblue]

@jelhan - ya, totally agree! We'll need to ensure that the API docs are updated at the time the deprecation guide lands.

@pzuraq - Would you mind double checking the prose here to see if we need to explicitly call that out? I think it may be already included in the existing prose RE: "How we teach this", but would love a second set of 👀...

[knownasilya]

Regarding implementing this, should this be a deprecation log on build? Since it's a build time transform?

[chancancode]

I think either would be acceptable, but generally if we can do it at build time that would be preferable IMO.

[rwjblue]

Agree. Doing it in the build gives us easier access to actual line / column numbers which is very helpful.