Skip to content

rfc: ember-data | state-machine-update - #737

Closed
runspired wants to merge 5 commits into
emberjs:masterfrom
runspired:ember-data/state-machine-update
Closed

rfc: ember-data | state-machine-update#737
runspired wants to merge 5 commits into
emberjs:masterfrom
runspired:ember-data/state-machine-update

Conversation

@runspired

@runspired runspired commented Apr 24, 2021

Copy link
Copy Markdown
Contributor

Full Text: Rendered
Implementation PR: warp-drive-data/warp-drive#7475

@runspired runspired added the T-ember-data RFCs that impact the ember-data library label Apr 24, 2021
@runspired

Copy link
Copy Markdown
Contributor Author

After discussion there is some disagreement over whether this is useful given once the RECORD_DATA_STATE and RECORD_DATA_ERRORS flags are activated we intend to deprecate the state-machine entirely. Adding new sub-states only to deprecate all of them soon thereafter feels somewhat awkward.

However, the boolean flag changes this proposes are states which need to be possible in the new world as well. We are going to investigate making the boolean flags work for the states proposed here without causing any changes to stateName, and ensure that they work in both worlds. We will revisit this with a mind to update the RECORD_DATA_STATE rfc if that cannot be achieved.

@runspired

Copy link
Copy Markdown
Contributor Author

Closing in favor of removal of the state machine entirely. The state machine has been refactored away from public APIs in warp-drive-data/warp-drive#7258 and we will RFC a deprecation for currentState.stateName. The flags will remain public API on model and flag states can be made to correctly reflect truthiness in deletion / empty-state without this RFC.

@runspired runspired closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-ember-data RFCs that impact the ember-data library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant