Adds Logging and Debugging Context API#753
Conversation
| This would likely be very costly from a performance perspective, and would | ||
| likely be prohibitive. | ||
|
|
||
| - We could only ship this API in development and not production, relaxing the |
There was a problem hiding this comment.
could there be an option to opt in to stripping this or other apis(?) out only in production?
There was a problem hiding this comment.
I think the cost here would be minimal enough that it won't really matter, and I think there could be broader repercussions to consider if we allowed that. For instance, some apps/addons may assume it exists, and stop working if it does not. I also worry about increasing implementation cost, and increased cost for Embroider to add another config option. That said, I'm open to the idea, would definitely like to see what others think about it.
| individual objects. When one is found, it is called and passed the object that | ||
| `getDebuggingContext` was called on. | ||
|
|
||
| ### setDebuggingContextGenerator |
There was a problem hiding this comment.
Can you update to include information about what happens if setDebuggingContextGenerator is called twice?
| ## Motivation | ||
|
|
||
| Currently, it can be pretty difficult to understand what caused an error within | ||
| an Ember application. Errors can occur almost anywhere at any time. They can be |
There was a problem hiding this comment.
This seems extremely useful for ember-data!
|
The general idea here seems really useful. Is there still interest in moving this forwards? |
7 participants
Rendered