Skip to content

Default workspace settings of code editors - #856

Closed
kaermorchen wants to merge 5 commits into
emberjs:masterfrom
kaermorchen:default-workspace-settings
Closed

Default workspace settings of code editors#856
kaermorchen wants to merge 5 commits into
emberjs:masterfrom
kaermorchen:default-workspace-settings

Conversation

@kaermorchen

Copy link
Copy Markdown

Default workspace settings will help new developers to start working on Ember projects.

Rendered

@bertdeblock bertdeblock added the T-ember-cli RFCs that impact the ember-cli library label Oct 9, 2022
@Windvis

Windvis commented Oct 10, 2022

Copy link
Copy Markdown

I think it would be better to look at something like ember-apply instead. Not everyone in a team will use VS Code and I really dislike that these kind of files are part of a project's repo.

Adding more conditional complexity to ember-cli itself increases the maintenance burden on the cli team and any updates to these files are bound to the ember-cli release cycle as well. It feels safer to keep it separate so each team can tweak and ship its own default configs if needed.

@MrChocolatine

Copy link
Copy Markdown
Contributor

I think it would be better to look at something like ember-apply instead. Not everyone in a team will use VS Code and I really dislike that these kind of files are part of a project's repo.

Adding more conditional complexity to ember-cli itself increases the maintenance burden on the cli team and any updates to these files are bound to the ember-cli release cycle as well. It feels safer to keep it separate so each team can tweak and ship its own default configs if needed.

I completely agree with what @Windvis said. In my opinion this should not be part of a JS framework.

@jrjohnson

Copy link
Copy Markdown
Contributor

These are great recommendations @kaermorchen, if you added them to ember-apply I'd recommend them for everyone on my team. I do tend to agree that while VSCode is super popular right now it's probably not a good idea to push this stuff into ember-cli as the most popular editor has changed at least 3x since I started working with ember 😁

@kaermorchen

Copy link
Copy Markdown
Author

Thanks @Windvis and all for the opinions and suggestions they are good for me.

I have taken a look at ember-apply and it seems a perfect solution for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-ember-cli RFCs that impact the ember-cli library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants