New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Deprecations in Deprecations Guide #2256

Closed
Gaurav0 opened this Issue Jul 15, 2015 · 22 comments

Comments

Projects
None yet
9 participants
@Gaurav0
Contributor

Gaurav0 commented Jul 15, 2015

Please add to the deprecations guide here: http://emberjs.com/deprecations/v1.x/.

These are all of the deprecations in 1.13.x that need to be covered:

Thank you!

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Aug 10, 2015

Contributor

I just went through all the minutes on the list here, added the weeks that were missing (as in, happened after this initial issue was filed) and pulled in all the specific details of the deprecations in each, as sublists. People have been fixing them piecemeal, so I wanted to be able to track exactly what was and wasn't done. I also checked off all the ones that had been done, and added links to their respective PRs.

Also, breaking it down like this hopefully makes these smaller tasks, so more people can jump in and help with little parts.

Contributor

wifelette commented Aug 10, 2015

I just went through all the minutes on the list here, added the weeks that were missing (as in, happened after this initial issue was filed) and pulled in all the specific details of the deprecations in each, as sublists. People have been fixing them piecemeal, so I wanted to be able to track exactly what was and wasn't done. I also checked off all the ones that had been done, and added links to their respective PRs.

Also, breaking it down like this hopefully makes these smaller tasks, so more people can jump in and help with little parts.

@trek

This comment has been minimized.

Show comment
Hide comment
@trek

trek Aug 10, 2015

Member

I think @dstaley is working on a much larger version of this: dstaley/ember.js#1

Although I don't understand why he's tracking the issue on his branch vs mainline

Member

trek commented Aug 10, 2015

I think @dstaley is working on a much larger version of this: dstaley/ember.js#1

Although I don't understand why he's tracking the issue on his branch vs mainline

@trek

This comment has been minimized.

Show comment
Hide comment
@trek

trek Aug 10, 2015

Member

Could the two of you work together to flesh out the full list please? Thanks.

Member

trek commented Aug 10, 2015

Could the two of you work together to flesh out the full list please? Thanks.

@trek trek self-assigned this Aug 10, 2015

@wifelette wifelette referenced this issue Aug 10, 2015

Open

v1.13 Deprecations Tracking Issue #1

0 of 35 tasks complete
@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Aug 10, 2015

Contributor

I commented there. Hopefully he'll jump in here and help :)

Contributor

wifelette commented Aug 10, 2015

I commented there. Hopefully he'll jump in here and help :)

@dstaley

This comment has been minimized.

Show comment
Hide comment
@dstaley

dstaley Aug 10, 2015

Contributor

@wifelette Definitely up for helping out! Just let me know what makes the most sense as far as where to put tracking issues, where to send PRs, etc. My original idea was to track the issues on my branches as PRs are sent to the branch, and then send on one big PR to mainline when it was done. If it makes more sense to track here and send PRs to a branch or something else just let me know.

Contributor

dstaley commented Aug 10, 2015

@wifelette Definitely up for helping out! Just let me know what makes the most sense as far as where to put tracking issues, where to send PRs, etc. My original idea was to track the issues on my branches as PRs are sent to the branch, and then send on one big PR to mainline when it was done. If it makes more sense to track here and send PRs to a branch or something else just let me know.

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Aug 10, 2015

Contributor

Howdy @dstaley! I think my thought was mostly the usual—PRs submitted to the website repo, added as a reference here, checked off when merged :)

I can't help write much of this content, but I can keep on top of it and get the PRs merged as quickly as possible, which has been part of the issue in the past. As in, sometimes people try helping with this, but then the PRs just sit around and waste away. Innocently of course, it's just that there's SO much else happening. So if I'm aggressively getting things merged, and we can get a couple people to help, this should hopefully be a much quicker task than it previously was.

Having the main bit of work living here means it's more discoverable, so I'm hoping more people notice it, and I'll be able to draw more specific attention to it. (Also I hadn't noticed your thing when I spent the couple hours sifting through everything last night, or the job might've been a lot easier 😜 Sounds like my life 😄 )

It's probably helpful to comment here when self-assigning an item, or add a username after the list item, a.k.a. "I'm tackling X", so other folks choose different things to tackle.

Contributor

wifelette commented Aug 10, 2015

Howdy @dstaley! I think my thought was mostly the usual—PRs submitted to the website repo, added as a reference here, checked off when merged :)

I can't help write much of this content, but I can keep on top of it and get the PRs merged as quickly as possible, which has been part of the issue in the past. As in, sometimes people try helping with this, but then the PRs just sit around and waste away. Innocently of course, it's just that there's SO much else happening. So if I'm aggressively getting things merged, and we can get a couple people to help, this should hopefully be a much quicker task than it previously was.

Having the main bit of work living here means it's more discoverable, so I'm hoping more people notice it, and I'll be able to draw more specific attention to it. (Also I hadn't noticed your thing when I spent the couple hours sifting through everything last night, or the job might've been a lot easier 😜 Sounds like my life 😄 )

It's probably helpful to comment here when self-assigning an item, or add a username after the list item, a.k.a. "I'm tackling X", so other folks choose different things to tackle.

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Aug 10, 2015

Contributor

Update: a bunch of helpful folk are hanging in the #documentation channel on the Ember Community Slack, interested in this very topic :)

Contributor

wifelette commented Aug 10, 2015

Update: a bunch of helpful folk are hanging in the #documentation channel on the Ember Community Slack, interested in this very topic :)

duggiefresh added a commit to duggiefresh/website that referenced this issue Aug 10, 2015

Deprecation guide for `Ember.create` and `Ember.keys`
- Adds links out to MDN for more information.

See #2256

duggiefresh added a commit to duggiefresh/website that referenced this issue Aug 10, 2015

Deprecation guide for `Ember.create` and `Ember.keys`
- Adds links out to MDN for more information.
- Apologies for the uninventive examples.

See #2256

duggiefresh added a commit to duggiefresh/website that referenced this issue Aug 10, 2015

Deprecation guide for `Ember.create` and `Ember.keys`
- Adds links out to MDN for more information.
- Apologies for the uninventive examples.

See #2256

@wifelette wifelette self-assigned this Aug 11, 2015

duggiefresh added a commit to duggiefresh/website that referenced this issue Aug 12, 2015

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Aug 23, 2015

Contributor

Thanks @martndemus, updated and linked to commit :)

Contributor

wifelette commented Aug 23, 2015

Thanks @martndemus, updated and linked to commit :)

@workmanw

This comment has been minimized.

Show comment
Hide comment
@workmanw

workmanw Aug 26, 2015

Contributor

Ember.SortableMixin seems to be gone in 2.0. I briefly looked around, but found no mention of its deprecation or disappearance.

Contributor

workmanw commented Aug 26, 2015

Ember.SortableMixin seems to be gone in 2.0. I briefly looked around, but found no mention of its deprecation or disappearance.

@ultimatemonty

This comment has been minimized.

Show comment
Hide comment
@ultimatemonty

ultimatemonty Sep 25, 2015

Contributor

Request to add emberjs/ember.js#11493 to the deprecations guide along with the reasoning behind it and acceptable alternatives. There are only 2 events that run only on component first run (didInitAttrs and didInsertElement) and the only place to init something like a jquery plugin wrapper is didInsertElement.

Thanks for all you folks do!

Contributor

ultimatemonty commented Sep 25, 2015

Request to add emberjs/ember.js#11493 to the deprecations guide along with the reasoning behind it and acceptable alternatives. There are only 2 events that run only on component first run (didInitAttrs and didInsertElement) and the only place to init something like a jquery plugin wrapper is didInsertElement.

Thanks for all you folks do!

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Oct 4, 2015

Contributor

@ultimatemonty Added to the list, thanks!

Contributor

wifelette commented Oct 4, 2015

@ultimatemonty Added to the list, thanks!

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Oct 4, 2015

Contributor

@workmanw SortableMixin was part of the controller feature in 1.13, and it was removed (along with many other controller deprecations). However, it's still available in the Legacy Controller Addon (at https://github.com/emberjs/ember-legacy-controllers/blob/master/addon/utils/sortable-mixin.js), and it would great to get a PR pointing people to the Mixin for that feature :)

Contributor

wifelette commented Oct 4, 2015

@workmanw SortableMixin was part of the controller feature in 1.13, and it was removed (along with many other controller deprecations). However, it's still available in the Legacy Controller Addon (at https://github.com/emberjs/ember-legacy-controllers/blob/master/addon/utils/sortable-mixin.js), and it would great to get a PR pointing people to the Mixin for that feature :)

romulomachado added a commit to romulomachado/ember-website that referenced this issue Oct 9, 2015

romulomachado added a commit to romulomachado/ember-website that referenced this issue Oct 9, 2015

romulomachado added a commit to romulomachado/ember-website that referenced this issue Oct 9, 2015

romulomachado added a commit to romulomachado/ember-website that referenced this issue Oct 9, 2015

@workmanw

This comment has been minimized.

Show comment
Hide comment
@workmanw

workmanw Oct 9, 2015

Contributor

@wifelette et al -- I'd be happy to submit a pull for SortableMixin ... but it wasn't actually deprecated in a literal sense, it was just kind of removed without warning. So it doesn't fit within the literal sense of "DEPRECATIONS ADDED IN 1.13". But if that seems okay, I'll open a PR.

Contributor

workmanw commented Oct 9, 2015

@wifelette et al -- I'd be happy to submit a pull for SortableMixin ... but it wasn't actually deprecated in a literal sense, it was just kind of removed without warning. So it doesn't fit within the literal sense of "DEPRECATIONS ADDED IN 1.13". But if that seems okay, I'll open a PR.

@workmanw

This comment has been minimized.

Show comment
Hide comment
@workmanw

workmanw Nov 6, 2015

Contributor

@wifelette Now that Ember.SortableMixin has been deprecated in Ember 1.x. I've added #2405.

Contributor

workmanw commented Nov 6, 2015

@wifelette Now that Ember.SortableMixin has been deprecated in Ember 1.x. I've added #2405.

mixonic added a commit to mixonic/website that referenced this issue Nov 14, 2015

mixonic added a commit to mixonic/website that referenced this issue Nov 14, 2015

@toddjordan

This comment has been minimized.

Show comment
Hide comment
@toddjordan

toddjordan Nov 20, 2015

Contributor

I can start gradually working through the some of the rest of these. I'll start at the batch from 1.13.7 and start working my way back. Starting with TrackedArray and SubArray...

Contributor

toddjordan commented Nov 20, 2015

I can start gradually working through the some of the rest of these. I'll start at the batch from 1.13.7 and start working my way back. Starting with TrackedArray and SubArray...

@toddjordan

This comment has been minimized.

Show comment
Hide comment
@toddjordan

toddjordan Dec 3, 2015

Contributor

ok, this week I'll move on to the @guid and @item deprecations from 1.13.2

Contributor

toddjordan commented Dec 3, 2015

ok, this week I'll move on to the @guid and @item deprecations from 1.13.2

@toddjordan

This comment has been minimized.

Show comment
Hide comment
@toddjordan

toddjordan Dec 3, 2015

Contributor

Moving on to the remaining 1.13.5 deprecations

Contributor

toddjordan commented Dec 3, 2015

Moving on to the remaining 1.13.5 deprecations

@acorncom

This comment has been minimized.

Show comment
Hide comment
@acorncom

acorncom Jan 8, 2016

Member

@wifelette @toddjordan #2428 was just merged. I just updated the checkboxes above to reflect that, which means at this point, I believe all deprecations are documented. Is that true?

@wifelette I'll leave the pleasure of closing this issue to you :-)

Member

acorncom commented Jan 8, 2016

@wifelette @toddjordan #2428 was just merged. I just updated the checkboxes above to reflect that, which means at this point, I believe all deprecations are documented. Is that true?

@wifelette I'll leave the pleasure of closing this issue to you :-)

@wifelette

This comment has been minimized.

Show comment
Hide comment
@wifelette

wifelette Jan 8, 2016

Contributor

Hah! I'm out this week and was legit sad that someone else would get to close it ;) Thanks everyone for helping make this happen!

Contributor

wifelette commented Jan 8, 2016

Hah! I'm out this week and was legit sad that someone else would get to close it ;) Thanks everyone for helping make this happen!

@wifelette wifelette closed this Jan 8, 2016

@Gaurav0

This comment has been minimized.

Show comment
Hide comment
@Gaurav0

Gaurav0 Jan 8, 2016

Contributor

Thank you all for your hard work on this.

Contributor

Gaurav0 commented Jan 8, 2016

Thank you all for your hard work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment