Skip to content
This repository has been archived by the owner. It is now read-only.

Observer guide needs a better disclaimer/warning #2865

Closed
martndemus opened this issue Mar 29, 2017 · 6 comments

Comments

@martndemus
Copy link
Contributor

commented Mar 29, 2017

As a best practices consultant I've run more than once into clients justifying using Observers because they are in the guides. There is a paragraph in there that warns readers that they might not be a good idea, but it's easily glossed over and not nearly as explicit enough to convince readers to not use them.

Most often I need to sit them down with Stefan Penners WGE Observer Tip Jar talk to convince them they really are a really bad practice.

I would also be fine with just removing the whole page, as I feel like observers are just a power user feature of the framework.

For reference, I'm talking about this page: https://guides.emberjs.com/v2.12.0/object-model/observers/

@rwjblue

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

IMHO, we should probably not introduce folks to observers in the guides. It is definitely still support API and whatnot, but I don't think observers should be considered one of the most important things for folks to grok when starting with Ember.

@martndemus

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2017

Should I open a PR removing the page from the guides?

@rwjblue

This comment has been minimized.

Copy link
Member

commented Mar 29, 2017

Seems good, but I'd like the leaning team folks to chime in and confirm before landing.

@locks

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

I'm somewhat wary of removing them from the Guides. Best practices by obscurity haven't worked out for us so far.

@acorncom

This comment has been minimized.

Copy link
Member

commented May 30, 2017

I'm somewhat wary of removing them from the Guides

Ditto. Seems like we need an power tool icon (or lightning bolt?) along with a "be very careful, here be sharp knives" and a link to Stef's video for background 😀

@locks

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

Addressed meanwhile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.