New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected toggling of displayed items in the API panes. #2267

Merged
merged 2 commits into from Aug 10, 2015

Conversation

Projects
None yet
3 participants
@ATMartin
Contributor

ATMartin commented Jul 25, 2015

In response to #2264: Now we're going through each of the pane's api-option inputs and confirming that they're toggled appropriately on each change. This appears to fix the issue of "Show inherited, show private, unshow inherited, wait why's that still there, oh god make them go away."

Hope this helps!

@chriskrycho

This comment has been minimized.

Show comment
Hide comment
@chriskrycho

chriskrycho Jul 25, 2015

Contributor

Testing this locally (since I was also working on a solution), and it has the side effect of toggling the contents of other panes (but not their checkboxes). E.g., check Private on the Index tab, then click the Methods tab: both Inherited and Private methods are shown there as well, but the checkbox for Private is unchecked.

The behavior in #2264 is fixed along the way, though!

Contributor

chriskrycho commented Jul 25, 2015

Testing this locally (since I was also working on a solution), and it has the side effect of toggling the contents of other panes (but not their checkboxes). E.g., check Private on the Index tab, then click the Methods tab: both Inherited and Private methods are shown there as well, but the checkbox for Private is unchecked.

The behavior in #2264 is fixed along the way, though!

@ATMartin

This comment has been minimized.

Show comment
Hide comment
@ATMartin

ATMartin Jul 25, 2015

Contributor

Ahh, good catch, thanks! Will see if I can nudge that out of there.

Contributor

ATMartin commented Jul 25, 2015

Ahh, good catch, thanks! Will see if I can nudge that out of there.

@ATMartin

This comment has been minimized.

Show comment
Hide comment
@ATMartin

ATMartin Jul 25, 2015

Contributor

I probably could have just --amended that into the original. This lets the selections persist across panes though. Newish to this, just let me know if I need to squash those changes together.

Contributor

ATMartin commented Jul 25, 2015

I probably could have just --amended that into the original. This lets the selections persist across panes though. Newish to this, just let me know if I need to squash those changes together.

wifelette added a commit that referenced this pull request Aug 10, 2015

Merge pull request #2267 from ATMartin/master
Fix unexpected toggling of displayed items in the API panes.

@wifelette wifelette merged commit d4d84ff into emberjs:master Aug 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment