Skip to content
This repository has been archived by the owner. It is now read-only.

Fix unexpected toggling of displayed items in the API panes. #2267

Merged
merged 2 commits into from Aug 10, 2015

Conversation

@ATMartin
Copy link
Contributor

@ATMartin ATMartin commented Jul 25, 2015

In response to #2264: Now we're going through each of the pane's api-option inputs and confirming that they're toggled appropriately on each change. This appears to fix the issue of "Show inherited, show private, unshow inherited, wait why's that still there, oh god make them go away."

Hope this helps!

@chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Jul 25, 2015

Testing this locally (since I was also working on a solution), and it has the side effect of toggling the contents of other panes (but not their checkboxes). E.g., check Private on the Index tab, then click the Methods tab: both Inherited and Private methods are shown there as well, but the checkbox for Private is unchecked.

The behavior in #2264 is fixed along the way, though!

@ATMartin
Copy link
Contributor Author

@ATMartin ATMartin commented Jul 25, 2015

Ahh, good catch, thanks! Will see if I can nudge that out of there.

@ATMartin
Copy link
Contributor Author

@ATMartin ATMartin commented Jul 25, 2015

I probably could have just --amended that into the original. This lets the selections persist across panes though. Newish to this, just let me know if I need to squash those changes together.

wifelette added a commit that referenced this pull request Aug 10, 2015
Fix unexpected toggling of displayed items in the API panes.
@wifelette wifelette merged commit d4d84ff into emberjs:master Aug 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.