Skip to content
This repository has been archived by the owner. It is now read-only.

Improves the call to action in the frontpage #2562

Merged
merged 1 commit into from May 9, 2016

Conversation

Projects
None yet
3 participants
@locks
Copy link
Contributor

commented Apr 19, 2016

Screenshot:

Ember.js home page with new call to action widget

Improves the call to action in the frontpage
Includes the starting npm instructions but also a link to our quick
start.
Insert ship it squirrel meme here.

<div class="info">
<a href="/builds">More downloads</a>
<a href="https://guides.emberjs.com/v2.5.0/getting-started/quick-start/">View Quick Start guide</a>

This comment has been minimized.

Copy link
@rwjblue

rwjblue Apr 19, 2016

Member

This should use the same logic as the guides layout to figure out the version from the JSON file (IMO).

This comment has been minimized.

Copy link
@locks

locks Apr 24, 2016

Author Contributor

🤔 versions.json is in another domain, where do we configure guides.emberjs.com's CORS?

This comment has been minimized.

Copy link
@rwjblue

rwjblue Apr 24, 2016

Member

It is done in Ruby land at build time, CORS isn't a factor.

@rwjblue

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

One nitpick but this looks great!

@locks locks merged commit 1f49228 into master May 9, 2016

@locks locks deleted the frontpage-cta branch May 9, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.