Skip to content
This repository has been archived by the owner. It is now read-only.

responsive blog with pagination #2595

Merged
merged 1 commit into from May 27, 2016

Conversation

@nithindavid
Copy link
Contributor

nithindavid commented May 21, 2016

Added pagination to blog pages and made it responsive ! please close this #2594 duplicate Pull request

@nithindavid nithindavid referenced this pull request May 21, 2016
14 of 18 tasks complete
@locks

This comment has been minimized.

Copy link
Contributor

locks commented May 21, 2016

Can you post some screenshots/gifs so we can do a visual check, please?

@nithindavid

This comment has been minimized.

Copy link
Contributor Author

nithindavid commented May 23, 2016

Here are some screenshots

image
image
image
image

@acorncom

This comment has been minimized.

Copy link
Member

acorncom commented May 27, 2016

Looks good, thank you!

@acorncom acorncom merged commit 8b95245 into emberjs:master May 27, 2016
@nithindavid

This comment has been minimized.

Copy link
Contributor Author

nithindavid commented May 28, 2016

Blog authors will to have add "responsive: true" property to blog post pages to make them responsive

@mixonic

This comment has been minimized.

Copy link
Member

mixonic commented May 30, 2016

@webofnithin could you possibly make a followup PR where the default is responsive and old problematic articles are flagged responsive: false? I worry we will not remember to put responsive: true in the header of every blog post. There are several authors and keeping them up to date on this kind of boilerplate is hard. I'd prefer a responsive default is possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.