New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Sidebar and Meta Tag enhancements #3280

Merged
merged 11 commits into from May 21, 2018

Conversation

Projects
None yet
3 participants
@MelSumner
Copy link
Contributor

MelSumner commented Apr 14, 2018

  • Added more content to the side bar
  • added tags to blog posts: every post will have at least the year and the relevant Ember version
  • added responsive: true if it wasn't already there (it is still an issue but we don't know why, someone will have to sit down and figure it out)
  • moved the sidebar to the right (on smaller viewports, the sidebar moves below the content)
  • updated the visual design for the sidebar

If merged, the current blog:
image

Would now become this:
image

@locks locks temporarily deployed to ember-website-staging-pr-3280 Apr 14, 2018 Inactive

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 Apr 14, 2018 Inactive

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 Apr 14, 2018 Inactive

@MelSumner MelSumner requested a review from emberjs/learning-team-managers May 5, 2018

@MelSumner MelSumner changed the title [work in progress/experiment - do not merge] Blog: make it easier to read other posts May 5, 2018

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 Inactive

@MelSumner MelSumner changed the title Blog: make it easier to read other posts Blog: Sidebar and Meta Tag enhancements May 21, 2018

@sivakumar-kailasam

This comment has been minimized.

Copy link
Member

sivakumar-kailasam commented May 21, 2018

@MelSumner on mobile the regular blog pages seems fine. When viewing one of the tags, it seems like its lacking media queries on those pages.

All screenshots were taken on a pixel 2 xl,
https://ember-website-staging-pr-3280.herokuapp.com/blog/page/2/
ember-website-staging-pr-3280 herokuapp com_blog_page_2_ pixel 2 xl

https://ember-website-staging-pr-3280.herokuapp.com/blog/tags/2018.html

ember-website-staging-pr-3280 herokuapp com_blog_tags_2018 html pixel 2 xl

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 Inactive

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 Inactive

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 Inactive

@MelSumner MelSumner temporarily deployed to ember-website-staging-pr-3280 May 21, 2018 Inactive

@MelSumner

This comment has been minimized.

Copy link
Contributor

MelSumner commented May 21, 2018

@sivakumar-kailasam thanks for catching that, I needed to update the tab.html.erb to more accurately reflect current design. 👍

@MelSumner MelSumner merged commit de20e60 into master May 21, 2018

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@MelSumner MelSumner deleted the feature/blog-meta-cleanup branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment