Improve arm #1180
Merged
Improve arm #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anton-bondarev
commented
Jul 18, 2018
anton-bondarev
commented
- Improve arm/qemu
- Fix vmem_alloc for 2 level tables
- Add arm/integratorcp template
- Improve arm fpu (change deprecated fstm/fldm -> vstm/vldm )
Deryugin
reviewed
Jul 18, 2018
src/mem/vmem/vmem_alloc.c
Outdated
| @@ -114,6 +121,11 @@ mmu_pte_t *vmem_alloc_pte_table(void) { | |||
| log_debug("%p", addr); | |||
|
|
|||
| return addr; | |||
| #else | |||
| log_error("pte not using in this configuration"); | |||
There was a problem hiding this comment.
Replace this message with "PTE pool size is zero for current configuration", please.
Deryugin
reviewed
Jul 19, 2018
src/mem/vmem/vmem_alloc.c
Outdated
| @@ -46,11 +46,14 @@ | |||
|
|
|||
| static char pgd_raw[(PGD_COUNT + 1) * MMU_PGD_SIZE] __attribute__ ((aligned(MMU_PGD_SIZE))); | |||
| static char pmd_raw[(PMD_COUNT + 1) * MMU_PMD_SIZE] __attribute__ ((aligned(MMU_PMD_SIZE))); | |||
| static char pte_raw[(PTE_COUNT + 1) * MMU_PTE_SIZE] __attribute__ ((aligned(MMU_PTE_SIZE))); | |||
|
|
|||
There was a problem hiding this comment.
Remove this empty line, please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.