use realpath of engine's route when building resolver.json - #1622
Merged
Conversation
NullVoxPopuli
approved these changes
Oct 4, 2023
Member
Author
|
I've tested this against https://github.com/mansona/ember-inline-svg-bug-recreation and I've verified that it does indeed fix the issue that we're facing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves a problem that we face when we try to run embroider in an app where
node_moduleshas been symlinked. The issue arises because all webpack requests normalise the path of a package using fs.realpath so when we're trying to find the owningEngine of a package we will always get the wrong answer because package passed into that request will have the real path on disk (after removing symbolic link information)I have tested this locally and it also seems to unblock ember-cli/ember-cli#10370 because the ember-cli CI also does some shenanigans with linking node_modules