Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation on Centos 6.4 #116

Closed
pvanliefland opened this issue Jun 18, 2013 · 5 comments
Closed

Installation on Centos 6.4 #116

pvanliefland opened this issue Jun 18, 2013 · 5 comments
Labels

Comments

@pvanliefland
Copy link
Contributor

@pvanliefland pvanliefland commented Jun 18, 2013

Hello,

The version of ImageMagick provided by Centos 6.4 does not have the text interline feature.

The following instructions in api.py prevent the import of wand:

library.DrawSetTextInterlineSpacing.argtypes = [ctypes.c_void_p,
                                                    ctypes.c_double]

library.DrawGetTextInterlineSpacing.argtypes = [ctypes.c_void_p]
    library.DrawGetTextInterlineSpacing.restype = ctypes.c_double

Centos users that cannot install from source of from alternative repositories will probably be stuck with the same version of ImageMagick for some time... Would it be an option to provide the text interline feature to systems that support it without it being a requirement ?

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Jun 18, 2013

Can you let me know what is CentOS 6.4’s ImageMagick version?

@pvanliefland
Copy link
Contributor Author

@pvanliefland pvanliefland commented Jun 19, 2013

It is ImageMagick 6.5.4-7

Let me know if I can help, if you want to go ahead with my suggestion and you can tell me how you want it done I can try to do a pull request.

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Jun 19, 2013

@pvanliefland The easiest way I can currently think of is simply catching AttributeError from these lines and then raise an error when Drawing.text_interline_spacing property is touched. We should define a new error type for this (its name would be LibraryVersionError or such).

@pvanliefland
Copy link
Contributor Author

@pvanliefland pvanliefland commented Jun 19, 2013

Ok, I'll give it a try this week.

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Jun 19, 2013

Thank you. 😄

pvanliefland added a commit to pvanliefland/wand that referenced this issue Jun 23, 2013
Made DrawSetTextInterlineSpacing and DrawGetTextInterlineSpacing optional
Added exception in drawing api when trying to use those features when they are not available
Added specific exception class for library versions issues
pvanliefland added a commit to pvanliefland/wand that referenced this issue Jul 9, 2013
Made DrawSetTextInterlineSpacing and DrawGetTextInterlineSpacing optional
Added exception in drawing api when trying to use those features when they are not available
Added specific exception class for library versions issues
@dahlia dahlia closed this in 06c406e Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants