Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.rst copied to virtualenv root directory #460

Closed
thijstriemstra opened this issue Mar 2, 2020 · 3 comments
Closed

README.rst copied to virtualenv root directory #460

thijstriemstra opened this issue Mar 2, 2020 · 3 comments

Comments

@thijstriemstra
Copy link
Contributor

@thijstriemstra thijstriemstra commented Mar 2, 2020

When you uninstall Wand (which was installed from pypi), something strange appears; apparently README.rst was copied to the root of my virtualenv during installation. This does not look right, it should not copy a project-specific README.rst in the root of my virtualenv.

$ pip uninstall Wand
Found existing installation: Wand 0.5.9
Uninstalling Wand-0.5.9:
  Would remove:
    /home/thijs/.virtualenvs/foo/README.rst
    /home/thijs/.virtualenvs/foo/lib/python3.8/site-packages/Wand-0.5.9.dist-info/*
    /home/thijs/.virtualenvs/foo/lib/python3.8/site-packages/wand/*
Proceed (y/n)? y
  Successfully uninstalled Wand-0.5.9

I'm using setuptools 45.2.0 and pip 20.0.2

@thijstriemstra
Copy link
Contributor Author

@thijstriemstra thijstriemstra commented Mar 2, 2020

The manifest looks similar to one of my projects: https://github.com/rm-hull/luma.core/blob/master/MANIFEST.in

But pip install luma.core does not copy the README.rst file.

@emcconville
Copy link
Owner

@emcconville emcconville commented Mar 2, 2020

Thanks for posting this. I think the README.rst file was listed in the setup.py, and can be removed.

@thijstriemstra
Copy link
Contributor Author

@thijstriemstra thijstriemstra commented Mar 2, 2020

yep that's it, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants