New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a modulate API method wrapper and tests. #134

Merged
merged 3 commits into from Sep 9, 2013

Conversation

3 participants
@mrdanpsmith
Contributor

mrdanpsmith commented Aug 9, 2013

I wanted to change the hue of an image using wand and found that in order to do so, I would have to use the low level API. Rather than do that (and recreate the wheel) I decided to try and add support in the image module for wand directly. It was relatively straightforward and I did a little hand functional test with the mona lisa PNG from wikipedia.

I decided to contribute this as I thought there might be other people out there who needed to use ImageMagick's modulate method. So, I read the contributor docs and created a test case and docstrings for my new method. If I need to do anything else to get this patch included, please let me know. I tried to follow the project standards as closely as I could.

Thanks,

Dan

@coveralls

This comment has been minimized.

coveralls commented Aug 9, 2013

Coverage Status

Coverage decreased (-0%) when pulling 4c8da1c on mrdanpsmith:master into 888434f on dahlia:master.

dahlia added a commit that referenced this pull request Aug 10, 2013

dahlia added a commit that referenced this pull request Aug 10, 2013

@dahlia

This comment has been minimized.

Collaborator

dahlia commented Aug 10, 2013

Merged to 0.3-maintenance branch, and it’s will be included to the next release (0.3.4). Thanks!

@dahlia dahlia merged commit 4c8da1c into emcconville:master Sep 9, 2013

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment