Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Image.colorspace property #135

Merged
merged 2 commits into from Sep 9, 2013
Merged

Conversation

@ksvladimir
Copy link
Contributor

@ksvladimir ksvladimir commented Aug 10, 2013

This property allows getting and setting the image colorspace.

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 10, 2013

Travis CI failed the test suite. It seems some older ImageMagick versions (at least 6.6.9-7 2012-08-17 Q16 which Travis CI currently uses) to return 'rgb' instead of 'srgb'.

Loading

@coveralls
Copy link

@coveralls coveralls commented Aug 10, 2013

Coverage Status

Coverage decreased (-0%) when pulling c3ae1de on ksvladimir:colorspace into 888434f on dahlia:master.

Loading

@ksvladimir
Copy link
Contributor Author

@ksvladimir ksvladimir commented Aug 10, 2013

Thanks for notifying me, I've fixed the testcase. It's so nice to work on a project with proper testing/coverage/style infrastructure!

Loading

dahlia added a commit that referenced this issue Aug 10, 2013
@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 10, 2013

Merged to 0.3-maintenance branch. It will be included in the next release (0.3.4). Thanks for your effort. 😄

Loading

@dahlia dahlia merged commit c3ae1de into emcconville:master Sep 9, 2013
1 check failed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants