Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to resize -sample image. #142

Merged
merged 4 commits into from Sep 9, 2013
Merged

Conversation

@mdallen22
Copy link
Contributor

@mdallen22 mdallen22 commented Aug 23, 2013

Image resize is too slow. Need the ability to quickly resize by sampling ... http://www.imagemagick.org/Usage/resize/#sample. This addition is basically a clone of the resize method with the arguments filter and blur removed, also calls to MagickResizeImage have been replaced with calls to MagickSampleImage.

@coveralls
Copy link

@coveralls coveralls commented Aug 23, 2013

Coverage Status

Coverage decreased (-1.02%) when pulling 139ed98 on mdallen22:master into 888434f on dahlia:master.

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 23, 2013

Thanks for your effort! Could you write some tests as well for this?

@coveralls
Copy link

@coveralls coveralls commented Aug 23, 2013

Coverage Status

Coverage decreased (-0.38%) when pulling 3ff8ba2 on mdallen22:master into 888434f on dahlia:master.

@mdallen22
Copy link
Contributor Author

@mdallen22 mdallen22 commented Aug 23, 2013

Tests are just resize's tests cases, replacing the resize calls with sample calls. sample is so similar to resize, I figure this should be sufficient.

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 23, 2013

@mdallen22 So then we can use pytest.parametrize() decorator here to eliminate duplicated tests for resize() and sample() methods. See also sequence_test.test_equals() and image_test.test_transform(). They both use pytest.parametrize() as well. 😄

@coveralls
Copy link

@coveralls coveralls commented Aug 23, 2013

Coverage Status

Coverage decreased (-0.67%) when pulling c4281a5 on mdallen22:master into 888434f on dahlia:master.

dahlia added a commit that referenced this pull request Aug 23, 2013
@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 23, 2013

Merged to 0.3-maintenace branch. It will be included in the next release (0.3.4). Thanks! 😀

@coveralls
Copy link

@coveralls coveralls commented Aug 26, 2013

Coverage Status

Coverage decreased (-0.81%) when pulling 9135cbc on mdallen22:master into 888434f on dahlia:master.

@dahlia dahlia merged commit 9135cbc into emcconville:master Sep 9, 2013
1 check failed
1 check failed
@dahlia
default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants