Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modulate segfault #158 #173

Closed
wants to merge 1 commit into from
Closed

Fix modulate segfault #158 #173

wants to merge 1 commit into from

Conversation

@fungt
Copy link
Contributor

@fungt fungt commented Mar 31, 2014

No description provided.

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Apr 1, 2014

Could you add a more test to reproduce the bug #158?

@fungt
Copy link
Contributor Author

@fungt fungt commented Apr 1, 2014

The segfault is somehow platform related, as I can reproduce the segfault basically by just calling the modulate() function on my MBP but not on my linux machine.

There is a unittest for modulate() under tests/image_test.py, and it will produce a segfault by running the test suite on a MBP without the fix.

dahlia added a commit that referenced this issue Apr 2, 2014
@dahlia
Copy link
Collaborator

@dahlia dahlia commented Apr 2, 2014

Cherry-picked 9476146 to 0.3-maintenance (see e8f19b9) since it’s a bug fix. (master is for 0.4, which is a next major release.)

Thanks!

@dahlia dahlia closed this Apr 2, 2014
@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 2, 2014

This bug fix is included in 0.3.8, a just released latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants