Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the initial example shown in the docs #18

Merged
merged 1 commit into from May 8, 2012

Conversation

@jcaxmacher
Copy link
Contributor

@jcaxmacher jcaxmacher commented May 8, 2012

Hello,
There seem to be two errors in the usage example on the index page of the docs.

  • r must be passed to format method of the file name instead of i
  • the file name passed to the save method of the image object should be a keyword argument to function correctly

I've submitted a pull request to fix this.

Thanks,
Jeremy

dahlia added a commit that referenced this pull request May 8, 2012
Error in the initial example shown in the docs
@dahlia dahlia merged commit 5b8e9c2 into emcconville:master May 8, 2012
@dahlia
Copy link
Collaborator

@dahlia dahlia commented May 8, 2012

Thank you!

@jcaxmacher
Copy link
Contributor Author

@jcaxmacher jcaxmacher commented May 8, 2012

No problem. Thank you for the awesome library!

I'd like to be able to watermark images, would you be open to a pull request for that functionality?

@dahlia
Copy link
Collaborator

@dahlia dahlia commented May 8, 2012

@obsoleter Of course you can freely send patches through pull requests. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.