Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MagickResetImagePage and as an optional argument for crop and rotate #20

Merged
merged 5 commits into from May 14, 2012

Conversation

@ghost
Copy link

@ghost ghost commented May 14, 2012

ImageMagick do not change the coordinate system after a crop or rotate, so the result of combine both is something unexpected.

It might be necessary to use a MagickResetImagePage after cropping or rotating to remove the page offset that will be left behind. This is especially true when you are going to write to an image format such as PNG that supports an image offset.

Without that, the resettest.png file in the tests would look like this: http://d.pr/i/pJaq instead of this: http://d.pr/i/gZpJ

@dahlia
Copy link
Collaborator

@dahlia dahlia commented May 14, 2012

Everything seems fine. Can you elaborate about reset_coords() method into its docstring?

Although it is a trivial thing, :class: role has to refer the actual class name for example bool instead of Boolean. :-)

@ghost
Copy link
Author

@ghost ghost commented May 14, 2012

Done

dahlia added a commit that referenced this pull request May 14, 2012
Support for MagickResetImagePage and as an optional argument for crop and rotate
@dahlia dahlia merged commit 17b366f into emcconville:master May 14, 2012
dahlia added a commit that referenced this pull request May 14, 2012
dahlia added a commit that referenced this pull request May 14, 2012
dahlia added a commit that referenced this pull request May 14, 2012
@dahlia
Copy link
Collaborator

@dahlia dahlia commented May 14, 2012

Merged and published the changelog for it: http://styleshare.github.com/wand/changes.html#version-0-2-0. (It is not published to PyPI yet however.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.