New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced libc.free calls with MagickRelinquishMemory #226

Merged
merged 3 commits into from Apr 4, 2015

Conversation

3 participants
@emcconville
Owner

emcconville commented Apr 1, 2015

Release 0.4.0 introduced libc module & @leaky_string decorator to manage memory allocated by MagickWand library under wand.drawing. However Windows user my experience undefined behavior, if not invalid address access errors, when calling methods that rely on libc.free. This pull request refactors wand.drawing API to leverage existing wand.api.c_magcik_char_p & library.MagickRelinquishMemory; thus, returns the responsibility of memory deallaction back to the MagickWand library.

@coveralls

This comment has been minimized.

coveralls commented Apr 1, 2015

Coverage Status

Coverage decreased (-0.08%) to 85.05% when pulling 5f47478 on emcconville:remove_leaky_string into bcd9ea6 on dahlia:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Apr 1, 2015

Coverage Status

Coverage decreased (-0.08%) to 85.05% when pulling 5f47478 on emcconville:remove_leaky_string into bcd9ea6 on dahlia:master.

@dahlia

This comment has been minimized.

Collaborator

dahlia commented Apr 3, 2015

Could you write changelog for this as well?

@emcconville

This comment has been minimized.

Owner

emcconville commented Apr 3, 2015

Absolutely. I'll updated the change log to cover issue #120 as well

@coveralls

This comment has been minimized.

coveralls commented Apr 3, 2015

Coverage Status

Coverage decreased (-0.23%) to 84.9% when pulling f8f1c53 on emcconville:remove_leaky_string into bcd9ea6 on dahlia:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Apr 3, 2015

Coverage Status

Coverage decreased (-0.23%) to 84.9% when pulling f8f1c53 on emcconville:remove_leaky_string into bcd9ea6 on dahlia:master.

dahlia added a commit that referenced this pull request Apr 4, 2015

Merge pull request #226 from emcconville/remove_leaky_string
Replaced libc.free calls with MagickRelinquishMemory

@dahlia dahlia merged commit e3b6c76 into emcconville:master Apr 4, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.23%) to 84.9%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dahlia

This comment has been minimized.

Collaborator

dahlia commented Apr 4, 2015

Thank you so much! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment