Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image.trim #26

Merged
merged 1 commit into from Jul 6, 2012
Merged

Add Image.trim #26

merged 1 commit into from Jul 6, 2012

Conversation

@jokull
Copy link
Contributor

@jokull jokull commented Jul 5, 2012

See MagickWand usage.

My editor removed some whitespace here and there. Hope you don’t mind.

dahlia added a commit that referenced this pull request Jul 6, 2012
@dahlia dahlia merged commit 2e9e077 into emcconville:master Jul 6, 2012
@dahlia
Copy link
Collaborator

@dahlia dahlia commented Jul 6, 2012

It seems to happen segmentation fault on PyPy. Have you any ideas to fix it?

@jokull
Copy link
Contributor Author

@jokull jokull commented Jul 6, 2012

It ran through the tests on OS X. Installed imagemagick through homebrew. There is a fuzz argument I ignored. Maybe that’s missing? Sorry I have no prior experience with ctypes.

@jokull
Copy link
Contributor Author

@jokull jokull commented Jul 6, 2012

Side note: It'd be cool if the trim function actually returned how much it trimmed off of the image.

dahlia added a commit that referenced this pull request Aug 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants