New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compare method #268

Merged
merged 4 commits into from Dec 21, 2015

Conversation

3 participants
@Perlmint
Contributor

Perlmint commented Dec 20, 2015

:type metric: :class:`basestring`
:returns: The difference image, the computed distortion between
the images
:rtype: :class:`wand.image.Image`, :class:`numbers.Integral`

This comment has been minimized.

@dahlia

dahlia Dec 20, 2015

Collaborator

Seems ambiguous between “image or integer” and “a pair of (image, integer).” I think simply tuple would be better. The type of elements should go to :returns: rather than :rtype:.

Perlmint added some commits Dec 20, 2015

Remove assert in test_compare.
It looks like get different distortion value with different version of
imagemagick.

tests of [Imagamagick](https://github.com/ImageMagick/ImageMagick/blob/master/tests/validate.c#L1180)
and [RMagick](https://github.com/rmagick/rmagick/blob/master/test/Image1.rb#L531)
don't check distortion value.
@Perlmint

This comment has been minimized.

Contributor

Perlmint commented Dec 20, 2015

I fixed docstring and test.

dahlia added a commit that referenced this pull request Dec 21, 2015

@dahlia dahlia merged commit aee0bab into emcconville:master Dec 21, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 85.236%
Details
@dahlia

This comment has been minimized.

Collaborator

dahlia commented Dec 21, 2015

Merged. Thanks!

@gentoo90

This comment has been minimized.

gentoo90 commented Feb 17, 2016

Any plans on releasing this feature on PYPI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment