New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exhaustively search for libraries in magick_home before calling find_… #320

Merged
merged 2 commits into from Apr 10, 2017

Conversation

5 participants
@acmanderson
Contributor

acmanderson commented Feb 16, 2017

…library. Previously this would only search for the first suffix (e.g. just libMagickWand.so) in MAGICK_HOME before resorting to find_library for the same suffix. For example, if libMagickWand-6.Q16.so was in magick_home but libMagickWand.so existed on the library path (e.g. if you compiled ImageMagick from source but had a different version already installed on your machine), it would not load the version of the library in magick_home. From what I could tell it didn't seem like there's a good way to write a test for this, but if there is I will add one.

acmanderson added some commits Feb 11, 2017

@coveralls

This comment has been minimized.

coveralls commented Feb 19, 2017

Coverage Status

Changes Unknown when pulling 4fe2c6b on acmanderson:master into ** on dahlia:master**.

@dahlia

dahlia approved these changes Mar 6, 2017

@jpgehrig

This comment has been minimized.

jpgehrig commented Mar 31, 2017

I just deployed this version to a Heroku app using the https://github.com/ello/heroku-buildpack-imagemagick.git buildpack. It fixed my problem.

Thank you for the fix and I'm looking forward to see this in Wand 0.4.5.

@jeanphix

This comment has been minimized.

jeanphix commented Apr 10, 2017

👍

@dahlia you should consider merging this.

@dahlia dahlia merged commit 23a73cf into emcconville:master Apr 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 85.242%
Details
@jeanphix

This comment has been minimized.

jeanphix commented Apr 10, 2017

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment