Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Image.resize() default filter type to 'undefined' #37

Merged
merged 1 commit into from Aug 17, 2012

Conversation

@pflorczyk
Copy link
Contributor

@pflorczyk pflorczyk commented Aug 17, 2012

If no filter type is given it's best to set it to undefined. IM will try to guess which one to use:
http://www.imagemagick.org/api/MagickCore/resize_8c_source.html#l02690
If size and filter are not defined and blur is 1.0 then Image.resize() will return copy of an image (same as Image.clone()):
http://www.imagemagick.org/api/MagickCore/resize_8c_source.html#l02672

@travisbot
Copy link

@travisbot travisbot commented Aug 17, 2012

This pull request passes (merged 3a871b0 into 8b1082c).

@dahlia
Copy link
Collaborator

@dahlia dahlia commented Aug 17, 2012

It seems definitely a better default! Thanks!

dahlia added a commit that referenced this issue Aug 17, 2012
Changed Image.resize() default filter type to 'undefined'
@dahlia dahlia merged commit 9b9c695 into emcconville:master Aug 17, 2012
1 check passed
dahlia added a commit that referenced this issue Aug 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants