Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move collections.abc to compat module #394

Merged
merged 1 commit into from Feb 13, 2019
Merged

Move collections.abc to compat module #394

merged 1 commit into from Feb 13, 2019

Conversation

@tvuotila
Copy link
Contributor

@tvuotila tvuotila commented Feb 13, 2019

Python 3.8 will drop support for
importing abstract base classes directly from collections module.
On python 3.7, direct import raises deprecation warning.

See https://docs.python.org/3/library/collections.html

Python 3.8 will drop support for
importing abstract base classes directly from collections module.
On python 3.7, direct import raises deprecation warning.
@coveralls
Copy link

@coveralls coveralls commented Feb 13, 2019

Coverage Status

Coverage decreased (-0.003%) to 83.432% when pulling f290939 on tvuotila:fix-collections-abc-deprecation into cdb01f3 on emcconville:master.

@emcconville emcconville merged commit f290939 into emcconville:master Feb 13, 2019
1 check passed
@emcconville
Copy link
Owner

@emcconville emcconville commented Feb 13, 2019

Thanks!

@emcconville emcconville added this to the 0.5.1 milestone Feb 13, 2019
@tvuotila tvuotila deleted the fix-collections-abc-deprecation branch Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants