Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "RuntimeError: dictionary changed size during iteration" #482

Merged
merged 1 commit into from May 15, 2020

Conversation

sbraz
Copy link
Contributor

@sbraz sbraz commented May 15, 2020

This was introduced by 447ddb7 and caused tests to fail with PyPy3.

Traceback (most recent call last):
  File "/var/tmp/portage/dev-python/wand-0.6.0/work/Wand-0.6.0/wand/resource.py", line 71, in shutdown
    for addr in allocation_map:
RuntimeError: dictionary changed size during iteration
debug: OperationError:
debug:  operror-type: RuntimeError
debug:  operror-value: dictionary changed size during iteration

CPython raises an error too but still returns an exit code of 0.

447ddb7 was pushed just before releasing 0.6.0 so I never had a chance to test it.

Do you think you'll make a minor release for this or should I patch 0.6.0 for Gentoo?

This was introduced by 447ddb7 and caused
tests to fail with PyPy3.
@coveralls
Copy link

@coveralls coveralls commented May 15, 2020

Coverage Status

Coverage remained the same at 89.283% when pulling 24b1cef on sbraz:dictionary_size into e687571 on emcconville:master.

@emcconville
Copy link
Owner

@emcconville emcconville commented May 15, 2020

I'll have the patch out in the next hour

@emcconville emcconville merged commit 24b1cef into emcconville:master May 15, 2020
4 checks passed
@emcconville
Copy link
Owner

@emcconville emcconville commented May 15, 2020

Released!

@emcconville
Copy link
Owner

@emcconville emcconville commented May 15, 2020

This was my bad with 447ddb7 . Trying to be clever & clean-up the code before release, but failed to repeat the test cases outside tox. Lessons learned the hard way.

@sbraz
Copy link
Contributor Author

@sbraz sbraz commented May 15, 2020

No worries :) Thanks for the quick merge!

@sbraz
Copy link
Contributor Author

@sbraz sbraz commented May 15, 2020

I think you linked to the wrong issue in the release info.

@emcconville
Copy link
Owner

@emcconville emcconville commented May 15, 2020

🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants