Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for #504 #505

Merged
merged 2 commits into from Nov 17, 2020
Merged

Possible fix for #504 #505

merged 2 commits into from Nov 17, 2020

Conversation

emcconville
Copy link
Owner

Check architectures label w/ platform.machine(), and assuming ImageMagick's MagickFloatType is defined as double.

Copy link

@mhillenbrand mhillenbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change on hardware; it fixes the issue (with the typo corrected).

looks good to me, thanks!

@@ -58,10 +59,16 @@ def load(lib, IM_VERSION, IM_QUANTUM_DEPTH, IM_HDRI):
is_im_6 = IM_VERSION < 0x700
is_im_7 = IM_VERSION >= 0x700

# Check for IBM Z Systems.
if 's309x' == platform.machine():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo / flipped digits, should be 's390x'.

Suggested change
if 's309x' == platform.machine():
if 's390x' == platform.machine():

for the sake of completeness, we could also cover the non-64-bit variant 's390' (i.e., without the 'x'), like this

Suggested change
if 's309x' == platform.machine():
if platform.machine() in ['s390', 's390x']:

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emcconville emcconville merged commit 01351d7 into master Nov 17, 2020
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants