New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolution parameter to constructor and read method. #75

Merged
merged 2 commits into from Nov 17, 2012

Conversation

2 participants
@niwinz
Contributor

niwinz commented Nov 17, 2012

This is a substitute pull request for (#67)

At the other pull-request indicabas that should put the method in the constructor rather read.

To read well the vector formats you need to put the resolution before reading the file. So it's very useful to have the resolution parameter in the constructor. So it's easy to keep using python context managers.

Also, I added the possibility that resolution is an integer and not a tuple. This emulates the behavior of the parameter "-density" from the command line, and may bring resolution=300, which actually becomes (300, 300).

I added appropriate tests.

dahlia added a commit that referenced this pull request Nov 17, 2012

Merge pull request #75 from niwibe/feature/resolution
Add resolution parameter to constructor and read method.

@dahlia dahlia merged commit 5d70c32 into emcconville:master Nov 17, 2012

1 check passed

default The Travis build passed
Details

dahlia added a commit that referenced this pull request Nov 17, 2012

dahlia added a commit that referenced this pull request Nov 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment