From 84259b9c232e974dcbbec8b0f8c9d0d8b1e77870 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Schubert?= Date: Tue, 14 Dec 2021 16:11:45 +0100 Subject: [PATCH] fix: conditionally disconnect attribute observer --- src/liquid/components/ld-button/ld-button.tsx | 2 +- src/liquid/components/ld-checkbox/ld-checkbox.tsx | 2 +- src/liquid/components/ld-input/ld-input.tsx | 2 +- src/liquid/components/ld-label/ld-label.tsx | 2 +- src/liquid/components/ld-radio/ld-radio.tsx | 2 +- src/liquid/components/ld-toggle/ld-toggle.tsx | 2 +- src/liquid/components/ld-typo/ld-typo.tsx | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/liquid/components/ld-button/ld-button.tsx b/src/liquid/components/ld-button/ld-button.tsx index ba43326ba9..3f064111ce 100644 --- a/src/liquid/components/ld-button/ld-button.tsx +++ b/src/liquid/components/ld-button/ld-button.tsx @@ -116,7 +116,7 @@ export class LdButton implements InnerFocusable, ClonesAttributes { this.el.removeEventListener('click', this.handleClick, { capture: true, }) - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } private clickHiddenButton() { diff --git a/src/liquid/components/ld-checkbox/ld-checkbox.tsx b/src/liquid/components/ld-checkbox/ld-checkbox.tsx index 166a4cf2bd..029def2f08 100644 --- a/src/liquid/components/ld-checkbox/ld-checkbox.tsx +++ b/src/liquid/components/ld-checkbox/ld-checkbox.tsx @@ -188,7 +188,7 @@ export class LdCheckbox implements InnerFocusable, ClonesAttributes { } disconnectedCallback() { - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } render() { diff --git a/src/liquid/components/ld-input/ld-input.tsx b/src/liquid/components/ld-input/ld-input.tsx index e5e6a700dd..eef39b6761 100644 --- a/src/liquid/components/ld-input/ld-input.tsx +++ b/src/liquid/components/ld-input/ld-input.tsx @@ -312,7 +312,7 @@ export class LdInput implements InnerFocusable, ClonesAttributes { } disconnectedCallback() { - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } render() { diff --git a/src/liquid/components/ld-label/ld-label.tsx b/src/liquid/components/ld-label/ld-label.tsx index ba233dc06d..0dc740431f 100644 --- a/src/liquid/components/ld-label/ld-label.tsx +++ b/src/liquid/components/ld-label/ld-label.tsx @@ -56,7 +56,7 @@ export class LdLabel implements ClonesAttributes { } disconnectedCallback() { - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } render() { diff --git a/src/liquid/components/ld-radio/ld-radio.tsx b/src/liquid/components/ld-radio/ld-radio.tsx index 329d13f24b..007497b8b0 100644 --- a/src/liquid/components/ld-radio/ld-radio.tsx +++ b/src/liquid/components/ld-radio/ld-radio.tsx @@ -219,7 +219,7 @@ export class LdRadio implements InnerFocusable, ClonesAttributes { } disconnectedCallback() { - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } render() { diff --git a/src/liquid/components/ld-toggle/ld-toggle.tsx b/src/liquid/components/ld-toggle/ld-toggle.tsx index 9b026c79c8..037e721e5d 100644 --- a/src/liquid/components/ld-toggle/ld-toggle.tsx +++ b/src/liquid/components/ld-toggle/ld-toggle.tsx @@ -179,7 +179,7 @@ export class LdToggle implements InnerFocusable, ClonesAttributes { } disconnectedCallback() { - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } render() { diff --git a/src/liquid/components/ld-typo/ld-typo.tsx b/src/liquid/components/ld-typo/ld-typo.tsx index a0850d4e55..9fc3c5f0b0 100644 --- a/src/liquid/components/ld-typo/ld-typo.tsx +++ b/src/liquid/components/ld-typo/ld-typo.tsx @@ -127,7 +127,7 @@ export class LdTypo implements ClonesAttributes { } disconnectedCallback() { - this.attributesObserver.disconnect() + this.attributesObserver?.disconnect() } render() {