From d2c354c9b00e7f19c44f8abc53a5c9be3c47110a Mon Sep 17 00:00:00 2001 From: Boris Diakur Date: Wed, 8 Nov 2023 11:34:48 +0100 Subject: [PATCH] style: resolve linting issues --- config/.eslintrc.cjs | 7 +- package.json | 8 +- pnpm-lock.yaml | 100 ++++++------------ src/docs/components/docs-main/docs-main.css | 3 +- src/liquid/components/ld-label/ld-label.css | 6 +- src/liquid/components/ld-modal/ld-modal.css | 3 +- .../ld-option-internal.shadow.css | 5 +- .../ld-select/test/ld-select.spec.ts | 25 +++-- src/liquid/components/ld-table/ld-table.css | 3 +- 9 files changed, 68 insertions(+), 92 deletions(-) diff --git a/config/.eslintrc.cjs b/config/.eslintrc.cjs index d223357111..758ac825a1 100644 --- a/config/.eslintrc.cjs +++ b/config/.eslintrc.cjs @@ -76,11 +76,12 @@ module.exports = { }, ignorePatterns: [ '**/bin/**/*', - '**/dist/**/*', - '**/hydrate/**/*', - '**/dist_docs/**/*', '**/coverage/**/*', '**/components.d.ts', + '**/dist/**/*', + '**/dist_docs/**/*', + '**/hydrate/**/*', + '**/out/**/*', '**/src/liquid/**/__mocks__/**/*', ], } diff --git a/package.json b/package.json index 0a823d978b..f101f957e0 100644 --- a/package.json +++ b/package.json @@ -55,6 +55,7 @@ "icons:update": "dotenv -e .env -- ts-node scripts/iconsUpdate.ts", "lint": "run-p lint:ts lint:eslint lint:styles", "lint:eslint": "eslint .", + "lint:eslint:fix": "eslint . --fix", "lint:styles": "stylelint ./src/**/*css", "lint:styles:fix": "stylelint ./src/**/*css --fix", "lint:ts": "tsc --noemit -p config/tsconfig.docs.json", @@ -148,7 +149,7 @@ "semantic-release": "^22.0.0", "shx": "^0.3.4", "stenciljs-web-types-generator": "^1.0.4", - "stylelint": "^15.6.0", + "stylelint": "^15.10.3", "stylelint-config-standard": "^34.0.0", "stylelint-declaration-strict-value": "^1.9.1", "stylelint-high-performance-animation": "^1.8.0", @@ -222,6 +223,11 @@ "printWidth": 80, "semi": false }, + "overrides": { + "stylelint": { + "cosmiconfig": "8.1.3" + } + }, "stylelint": { "extends": [ "./config/stylelint.config.cjs" diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index fe44b7b600..5f616526fe 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -229,23 +229,23 @@ devDependencies: specifier: ^1.0.4 version: 1.0.4 stylelint: - specifier: ^15.6.0 - version: 15.6.0(typescript@5.0.4) + specifier: ^15.10.3 + version: 15.11.0(typescript@5.0.4) stylelint-config-standard: specifier: ^34.0.0 - version: 34.0.0(stylelint@15.6.0) + version: 34.0.0(stylelint@15.11.0) stylelint-declaration-strict-value: specifier: ^1.9.1 - version: 1.9.1(stylelint@15.6.0) + version: 1.9.1(stylelint@15.11.0) stylelint-high-performance-animation: specifier: ^1.8.0 - version: 1.8.0(stylelint@15.6.0) + version: 1.8.0(stylelint@15.11.0) stylelint-no-unsupported-browser-features: specifier: ^7.0.0 - version: 7.0.0(stylelint@15.6.0) + version: 7.0.0(stylelint@15.11.0) stylelint-use-nesting: specifier: ^4.0.0 - version: 4.0.0(stylelint@15.6.0) + version: 4.0.0(stylelint@15.11.0) svgo: specifier: ^3.0.2 version: 3.0.2 @@ -1225,15 +1225,6 @@ packages: postcss: 8.4.21 dev: true - /@csstools/selector-specificity@2.2.0(postcss-selector-parser@6.0.13): - resolution: {integrity: sha512-+OJ9konv95ClSTOJCmMZqpd5+YGsB2S+x6w3E1oaM8UuR5j8nTNHYSz8c9BEPGDOCMQYIEEGlVPj/VY64iTbGw==} - engines: {node: ^14 || ^16 || >=18} - peerDependencies: - postcss-selector-parser: ^6.0.10 - dependencies: - postcss-selector-parser: 6.0.13 - dev: true - /@csstools/selector-specificity@3.0.0(postcss-selector-parser@6.0.13): resolution: {integrity: sha512-hBI9tfBtuPIi885ZsZ32IMEU/5nlZH/KOVYJCOh7gyMxaVLGmLedYqFN6Ui1LXkI8JlC8IsuC0rF0btcRZKd5g==} engines: {node: ^14 || ^16 || >=18} @@ -5122,6 +5113,13 @@ packages: flat-cache: 3.1.1 dev: true + /file-entry-cache@7.0.1: + resolution: {integrity: sha512-uLfFktPmRetVCbHe5UPuekWrQ6hENufnA46qEGbfACkK5drjTTdQYUragRgMjHldcbYG+nslUerqMPjbBSHXjQ==} + engines: {node: '>=12.0.0'} + dependencies: + flat-cache: 3.1.1 + dev: true + /file-uri-to-path@1.0.0: resolution: {integrity: sha512-0Zt+s3L7Vf1biwWZ29aARiVYLx7iMGnEUl9x33fbB/j3jR81u/O2LbqK+Bm1CDSNDKVtJ/YjwY7TUd5SkeLQLw==} requiresBuild: true @@ -7195,8 +7193,8 @@ packages: engines: {node: '>=6'} dev: true - /known-css-properties@0.27.0: - resolution: {integrity: sha512-uMCj6+hZYDoffuvAJjFAPz56E9uoowFHmTkqRtRq5WyC5Q6Cu/fTZKNQpX/RbzChBYLLl3lo8CjFZBAZXq9qFg==} + /known-css-properties@0.29.0: + resolution: {integrity: sha512-Ne7wqW7/9Cz54PDt4I3tcV+hAyat8ypyOGzYRJQfdxnnjeWsTxt1cy8pjvvKeI5kfXuyvULyeeAvwvvtAX3ayQ==} dev: true /ldjson-stream@1.2.1: @@ -7702,24 +7700,6 @@ packages: yargs-parser: 20.2.9 dev: true - /meow@9.0.0: - resolution: {integrity: sha512-+obSblOQmRhcyBt62furQqRAQpNyWXo8BuQ5bN7dG8wmwQ+vwHKp/rCFD4CrTP8CsDQD1sjoZ94K417XEUk8IQ==} - engines: {node: '>=10'} - dependencies: - '@types/minimist': 1.2.5 - camelcase-keys: 6.2.2 - decamelize: 1.2.0 - decamelize-keys: 1.1.1 - hard-rejection: 2.1.0 - minimist-options: 4.1.0 - normalize-package-data: 3.0.3 - read-pkg-up: 7.0.1 - redent: 3.0.0 - trim-newlines: 3.0.1 - type-fest: 0.18.1 - yargs-parser: 20.2.9 - dev: true - /merge-stream@2.0.0: resolution: {integrity: sha512-abv/qOcuPfk3URPfDzmZU1LKmuw8kT+0nIHvKrKgFrwifol/doWcdA4ZqsWQ8ENrFKkd67Mfpo/LovbIUsbt3w==} dev: true @@ -9126,10 +9106,6 @@ packages: postcss-value-parser: 4.2.0 dev: true - /postcss-media-query-parser@0.2.3: - resolution: {integrity: sha512-3sOlxmbKcSHMjlUXQZKQ06jOswE7oVkXPxmZdoB1r5l0q6gTFTQSHxNxOrCccElbW7dxNytifNEo8qidX2Vsig==} - dev: true - /postcss-merge-longhand@6.0.0(postcss@8.4.21): resolution: {integrity: sha512-4VSfd1lvGkLTLYcxFuISDtWUfFS4zXe0FpF149AyziftPFQIWxjvFSKhA4MIxMe4XM3yTDgQMbSNgzIVxChbIg==} engines: {node: ^14 || ^16 || >=18.0} @@ -11103,45 +11079,45 @@ packages: postcss-selector-parser: 6.0.13 dev: true - /stylelint-config-recommended@13.0.0(stylelint@15.6.0): + /stylelint-config-recommended@13.0.0(stylelint@15.11.0): resolution: {integrity: sha512-EH+yRj6h3GAe/fRiyaoO2F9l9Tgg50AOFhaszyfov9v6ayXJ1IkSHwTxd7lB48FmOeSGDPLjatjO11fJpmarkQ==} engines: {node: ^14.13.1 || >=16.0.0} peerDependencies: stylelint: ^15.10.0 dependencies: - stylelint: 15.6.0(typescript@5.0.4) + stylelint: 15.11.0(typescript@5.0.4) dev: true - /stylelint-config-standard@34.0.0(stylelint@15.6.0): + /stylelint-config-standard@34.0.0(stylelint@15.11.0): resolution: {integrity: sha512-u0VSZnVyW9VSryBG2LSO+OQTjN7zF9XJaAJRX/4EwkmU0R2jYwmBSN10acqZisDitS0CLiEiGjX7+Hrq8TAhfQ==} engines: {node: ^14.13.1 || >=16.0.0} peerDependencies: stylelint: ^15.10.0 dependencies: - stylelint: 15.6.0(typescript@5.0.4) - stylelint-config-recommended: 13.0.0(stylelint@15.6.0) + stylelint: 15.11.0(typescript@5.0.4) + stylelint-config-recommended: 13.0.0(stylelint@15.11.0) dev: true - /stylelint-declaration-strict-value@1.9.1(stylelint@15.6.0): + /stylelint-declaration-strict-value@1.9.1(stylelint@15.11.0): resolution: {integrity: sha512-iIkMh2ukIfSTtJoEDgGq5cqUyYWP8NExPk2YSGcePtFikb7KmJoSi0QYajiZRxge/PTbYspci7nIcrtArJlAsw==} peerDependencies: stylelint: '>=7 <=14' dependencies: css-values: 0.1.0 shortcss: 0.1.3 - stylelint: 15.6.0(typescript@5.0.4) + stylelint: 15.11.0(typescript@5.0.4) dev: true - /stylelint-high-performance-animation@1.8.0(stylelint@15.6.0): + /stylelint-high-performance-animation@1.8.0(stylelint@15.11.0): resolution: {integrity: sha512-wxHt+F7Z54mtGZpbdMwUtpfQwr81uiml39EFCCdZAbVnEO7Wl0Mh5ncmgbxH42xpB5z79eIgHI62qtKfUmWzhg==} peerDependencies: stylelint: ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0 dependencies: postcss-value-parser: 4.2.0 - stylelint: 15.6.0(typescript@5.0.4) + stylelint: 15.11.0(typescript@5.0.4) dev: true - /stylelint-no-unsupported-browser-features@7.0.0(stylelint@15.6.0): + /stylelint-no-unsupported-browser-features@7.0.0(stylelint@15.11.0): resolution: {integrity: sha512-O5VYlBhr+lpJ6jeTJSy+SMbHJhW5h5EJxsoicYcTi/07m45V/CF1mQidwRQLjv8y9BFQMpioWz60O89IkmbaNw==} engines: {node: '>=16'} peerDependencies: @@ -11150,27 +11126,27 @@ packages: doiuse: 6.0.2 lodash: 4.17.21 postcss: 8.4.21 - stylelint: 15.6.0(typescript@5.0.4) + stylelint: 15.11.0(typescript@5.0.4) dev: true - /stylelint-use-nesting@4.0.0(stylelint@15.6.0): + /stylelint-use-nesting@4.0.0(stylelint@15.11.0): resolution: {integrity: sha512-v1DG1GsV2Ojy8y/yoWZGLxeZSLNenrpEGtFY6qq921G8ABni9XbBJRbD9jDQAsPPhOnLz7Cy9B2DfNk05IOKIw==} engines: {node: '>=16.0.0'} peerDependencies: stylelint: '>= 10' dependencies: - stylelint: 15.6.0(typescript@5.0.4) + stylelint: 15.11.0(typescript@5.0.4) dev: true - /stylelint@15.6.0(typescript@5.0.4): - resolution: {integrity: sha512-Cqzpc8tvJm77KaM8qUbhpJ/UYK55Ia0whQXj4b9IId9dlPICO7J8Lyo15SZWiHxKjlvy3p5FQor/3n6i8ignXg==} + /stylelint@15.11.0(typescript@5.0.4): + resolution: {integrity: sha512-78O4c6IswZ9TzpcIiQJIN49K3qNoXTM8zEJzhaTE/xRTCZswaovSEVIa/uwbOltZrk16X4jAxjaOhzz/hTm1Kw==} engines: {node: ^14.13.1 || >=16.0.0} hasBin: true dependencies: '@csstools/css-parser-algorithms': 2.3.2(@csstools/css-tokenizer@2.2.1) '@csstools/css-tokenizer': 2.2.1 '@csstools/media-query-list-parser': 2.1.5(@csstools/css-parser-algorithms@2.3.2)(@csstools/css-tokenizer@2.2.1) - '@csstools/selector-specificity': 2.2.0(postcss-selector-parser@6.0.13) + '@csstools/selector-specificity': 3.0.0(postcss-selector-parser@6.0.13) balanced-match: 2.0.0 colord: 2.9.3 cosmiconfig: 8.3.6(typescript@5.0.4) @@ -11179,7 +11155,7 @@ packages: debug: 4.3.4 fast-glob: 3.3.2 fastest-levenshtein: 1.0.16 - file-entry-cache: 6.0.1 + file-entry-cache: 7.0.1 global-modules: 2.0.0 globby: 11.1.0 globjoin: 0.1.4 @@ -11188,14 +11164,13 @@ packages: import-lazy: 4.0.0 imurmurhash: 0.1.4 is-plain-object: 5.0.0 - known-css-properties: 0.27.0 + known-css-properties: 0.29.0 mathml-tag-names: 2.1.3 - meow: 9.0.0 + meow: 10.1.5 micromatch: 4.0.5 normalize-path: 3.0.0 picocolors: 1.0.0 postcss: 8.4.31 - postcss-media-query-parser: 0.2.3 postcss-resolve-nested-selector: 0.1.1 postcss-safe-parser: 6.0.0(postcss@8.4.31) postcss-selector-parser: 6.0.13 @@ -11207,7 +11182,6 @@ packages: supports-hyperlinks: 3.0.0 svg-tags: 1.0.0 table: 6.8.1 - v8-compile-cache: 2.4.0 write-file-atomic: 5.0.1 transitivePeerDependencies: - supports-color @@ -11941,10 +11915,6 @@ packages: resolution: {integrity: sha512-wa7YjyUGfNZngI/vtK0UHAN+lgDCxBPCylVXGp0zu59Fz5aiGtNXaq3DhIov063MorB+VfufLh3JlF2KdTK3xg==} dev: true - /v8-compile-cache@2.4.0: - resolution: {integrity: sha512-ocyWc3bAHBB/guyqJQVI5o4BZkPhznPYUG2ea80Gond/BgNWpap8TOmLSeeQG7bnh2KMISxskdADG59j7zruhw==} - dev: true - /v8-to-istanbul@7.1.2: resolution: {integrity: sha512-TxNb7YEUwkLXCQYeudi6lgQ/SZrzNO4kMdlqVxaZPUIUjCv6iSSypUQX70kNBSERpQ8fk48+d61FXk+tgqcWow==} engines: {node: '>=10.10.0'} diff --git a/src/docs/components/docs-main/docs-main.css b/src/docs/components/docs-main/docs-main.css index 86f4afce46..d4f75f9d3a 100644 --- a/src/docs/components/docs-main/docs-main.css +++ b/src/docs/components/docs-main/docs-main.css @@ -357,8 +357,7 @@ } > table { - overflow-x: scroll; - overflow-y: hidden; + overflow: scroll hidden; min-width: 100%; text-align: left; border-collapse: collapse; diff --git a/src/liquid/components/ld-label/ld-label.css b/src/liquid/components/ld-label/ld-label.css index 0f679435ef..28380826eb 100644 --- a/src/liquid/components/ld-label/ld-label.css +++ b/src/liquid/components/ld-label/ld-label.css @@ -18,8 +18,7 @@ color: var(--ld-label-col); font: var(--ld-typo-label-s); display: inline-grid; - row-gap: var(--ld-label-row-gap); - column-gap: 0; + gap: var(--ld-label-row-gap) 0; max-width: 100%; align-content: flex-start; } @@ -28,8 +27,7 @@ .ld-label--right { justify-content: flex-start; align-items: center; - column-gap: var(--ld-label-column-gap); - row-gap: 0; + gap: 0 var(--ld-label-column-gap); > ::slotted(.ld-checkbox), > .ld-checkbox, diff --git a/src/liquid/components/ld-modal/ld-modal.css b/src/liquid/components/ld-modal/ld-modal.css index df353b319c..2a17738cb2 100644 --- a/src/liquid/components/ld-modal/ld-modal.css +++ b/src/liquid/components/ld-modal/ld-modal.css @@ -137,7 +137,7 @@ dialog.ld-modal--blurry-backdrop, /* custom icon cross */ .ld-modal__x { - align-self: flex-start; + place-self: flex-start flex-end; appearance: none; background-color: transparent; border: solid transparent var(--ld-sp-8); @@ -145,7 +145,6 @@ dialog.ld-modal--blurry-backdrop, cursor: pointer; display: inline-flex; height: 3rem; - justify-self: flex-end; margin: auto calc(var(--ld-sp-16) * -1) auto auto; overflow: hidden; position: relative; diff --git a/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.shadow.css b/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.shadow.css index 243df8d7b4..0e76ed24e4 100644 --- a/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.shadow.css +++ b/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.shadow.css @@ -46,10 +46,9 @@ color: var(--ld-option-text-col); background-color: var(--ld-option-bg-col); padding-block: var(--ld-sp-8); - padding-inline-end: var(--ld-sp-12); - padding-inline-start: calc( + padding-inline: calc( var(--ld-option-padding-inline-start) + var(--ld-option-indent, 0px) - ); + ) var(--ld-sp-12); font: var(--ld-typo-label-m); min-height: 2.5rem; white-space: nowrap; diff --git a/src/liquid/components/ld-select/test/ld-select.spec.ts b/src/liquid/components/ld-select/test/ld-select.spec.ts index 95b722d662..faed6922b9 100644 --- a/src/liquid/components/ld-select/test/ld-select.spec.ts +++ b/src/liquid/components/ld-select/test/ld-select.spec.ts @@ -114,8 +114,9 @@ describe('ld-select', () => { await page.waitForChanges() const ldSelectPopper = await page.body.querySelector('ld-select-popper') - const ldSelectPopperEl = - await ldSelectPopper.shadowRoot.querySelector('.ld-select-popper') + const ldSelectPopperEl = await ldSelectPopper.shadowRoot.querySelector( + '.ld-select-popper' + ) const slottedOptions = ldSelect.querySelectorAll('ld-option') const internalOptions = ldSelectPopper.querySelectorAll('ld-option-internal') @@ -693,8 +694,9 @@ describe('ld-select', () => { await triggerPopperWithClick(page) const ldSelectPopper = await page.body.querySelector('ld-select-popper') - const ldSelectPopperEl = - await ldSelectPopper.shadowRoot.querySelector('.ld-select-popper') + const ldSelectPopperEl = await ldSelectPopper.shadowRoot.querySelector( + '.ld-select-popper' + ) expect( ldSelectPopperEl.classList.contains('ld-select-popper--sm') ).toBeTruthy() @@ -2484,8 +2486,9 @@ describe('ld-select', () => { ) expect(btnTrigger.getAttribute('aria-expanded')).toEqual('true') - const internalOption0 = - await page.body.querySelector('ld-option-internal') + const internalOption0 = await page.body.querySelector( + 'ld-option-internal' + ) expect(internalOption0.tagName).toEqual('LD-OPTION-INTERNAL') const ev = { @@ -2518,8 +2521,9 @@ describe('ld-select', () => { ) expect(btnTrigger.getAttribute('aria-expanded')).toEqual('true') - const internalOption0 = - await page.body.querySelector('ld-option-internal') + const internalOption0 = await page.body.querySelector( + 'ld-option-internal' + ) expect(internalOption0.tagName).toEqual('LD-OPTION-INTERNAL') const ev = { @@ -2552,8 +2556,9 @@ describe('ld-select', () => { ) expect(btnTrigger.getAttribute('aria-expanded')).toEqual('true') - const internalOption0 = - await page.body.querySelector('ld-option-internal') + const internalOption0 = await page.body.querySelector( + 'ld-option-internal' + ) expect(internalOption0.tagName).toEqual('LD-OPTION-INTERNAL') const ev = { diff --git a/src/liquid/components/ld-table/ld-table.css b/src/liquid/components/ld-table/ld-table.css index c7a08923f1..25a5ae5c02 100644 --- a/src/liquid/components/ld-table/ld-table.css +++ b/src/liquid/components/ld-table/ld-table.css @@ -71,8 +71,7 @@ gap: var(--ld-sp-12); justify-content: flex-start; min-height: var(--ld-sp-40); - overflow-x: auto; - overflow-y: hidden; + overflow: auto hidden; padding-inline: var(--ld-table-cell-padding-x); position: relative; white-space: nowrap;