From ec3775f137decf4292b0047df73e351ed29d37b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Schubert?= Date: Wed, 13 Oct 2021 15:20:26 +0200 Subject: [PATCH] test(e2e): fix focus outline --- src/liquid/components/ld-button/ld-button.tsx | 2 +- .../test/__snapshots__/ld-button.spec.ts.snap | 28 +++++++++---------- .../components/ld-input-message/readme.md | 4 +-- src/liquid/components/ld-input/ld-input.tsx | 4 +-- .../test/__snapshots__/ld-input.spec.ts.snap | 18 ++++++------ .../ld-option-internal/ld-option-internal.tsx | 2 +- src/liquid/components/ld-select/ld-select.tsx | 6 ++-- src/liquid/components/ld-select/readme.md | 1 + .../components/ld-tabs/ld-tab/ld-tab.tsx | 2 +- .../components/ld-tabs/ld-tab/readme.md | 1 + .../__snapshots__/ld-tablist.spec.ts.snap | 12 ++++---- .../test/__snapshots__/ld-tabs.spec.ts.snap | 8 +++--- .../ld-tooltip/test/ld-tooltip.e2e.ts | 1 - src/liquid/utils/e2e-tests.ts | 5 ++-- 14 files changed, 48 insertions(+), 46 deletions(-) diff --git a/src/liquid/components/ld-button/ld-button.tsx b/src/liquid/components/ld-button/ld-button.tsx index 91edef2be2..6fc512cbfe 100644 --- a/src/liquid/components/ld-button/ld-button.tsx +++ b/src/liquid/components/ld-button/ld-button.tsx @@ -124,7 +124,7 @@ export class LdButton implements InnerFocusable { class={cl} disabled={this.disabled} href={this.href} - part="button" + part="button focusable" ref={(el: HTMLAnchorElement | HTMLButtonElement) => (this.button = el)} rel={this.target === '_blank' ? 'noreferrer noopener' : undefined} target={this.target} diff --git a/src/liquid/components/ld-button/test/__snapshots__/ld-button.spec.ts.snap b/src/liquid/components/ld-button/test/__snapshots__/ld-button.spec.ts.snap index c297cab678..783126ac3a 100644 --- a/src/liquid/components/ld-button/test/__snapshots__/ld-button.spec.ts.snap +++ b/src/liquid/components/ld-button/test/__snapshots__/ld-button.spec.ts.snap @@ -3,7 +3,7 @@ exports[`ld-button align text 1`] = ` - @@ -14,7 +14,7 @@ exports[`ld-button align text 1`] = ` exports[`ld-button as anchor 1`] = ` - + @@ -25,7 +25,7 @@ exports[`ld-button as anchor 1`] = ` exports[`ld-button as progress button 1`] = ` - @@ -37,7 +37,7 @@ exports[`ld-button as progress button 1`] = ` exports[`ld-button as progress button pending 1`] = ` - @@ -49,7 +49,7 @@ exports[`ld-button as progress button pending 1`] = ` exports[`ld-button danger 1`] = ` - @@ -60,7 +60,7 @@ exports[`ld-button danger 1`] = ` exports[`ld-button disabled 1`] = ` - @@ -71,7 +71,7 @@ exports[`ld-button disabled 1`] = ` exports[`ld-button ghost 1`] = ` - @@ -82,7 +82,7 @@ exports[`ld-button ghost 1`] = ` exports[`ld-button highlight 1`] = ` - @@ -93,7 +93,7 @@ exports[`ld-button highlight 1`] = ` exports[`ld-button justify content 1`] = ` - @@ -104,7 +104,7 @@ exports[`ld-button justify content 1`] = ` exports[`ld-button on-brand-color 1`] = ` - @@ -115,7 +115,7 @@ exports[`ld-button on-brand-color 1`] = ` exports[`ld-button renders 1`] = ` - @@ -126,7 +126,7 @@ exports[`ld-button renders 1`] = ` exports[`ld-button secondary 1`] = ` - @@ -137,7 +137,7 @@ exports[`ld-button secondary 1`] = ` exports[`ld-button secondary-on-brand-color 1`] = ` - @@ -148,7 +148,7 @@ exports[`ld-button secondary-on-brand-color 1`] = ` exports[`ld-button size 1`] = ` - diff --git a/src/liquid/components/ld-input-message/readme.md b/src/liquid/components/ld-input-message/readme.md index f133acf062..7b3ad86b88 100644 --- a/src/liquid/components/ld-input-message/readme.md +++ b/src/liquid/components/ld-input-message/readme.md @@ -86,8 +86,8 @@ This component is meant to be used in conjunction with the [`ld-input`](componen ## Shadow Parts -| Part | Description | -| -------- | ---------------------- | +| Part | Description | +| -------- | --------------------------- | | `"icon"` | Image tag used for the icon | diff --git a/src/liquid/components/ld-input/ld-input.tsx b/src/liquid/components/ld-input/ld-input.tsx index db781f41fe..d4ae259fce 100644 --- a/src/liquid/components/ld-input/ld-input.tsx +++ b/src/liquid/components/ld-input/ld-input.tsx @@ -139,7 +139,7 @@ export class LdInput implements InnerFocusable { onBlur={this.handleBlur} onFocus={this.handleFocus} onInput={this.handleInput.bind(this)} - part="input" + part="input focusable" placeholder={this.placeholder} ref={(el) => (this.input = el)} {...cloneAttributes(this.el)} @@ -161,7 +161,7 @@ export class LdInput implements InnerFocusable { onBlur={this.handleBlur} onFocus={this.handleFocus} onInput={this.handleInput.bind(this)} - part="input" + part="input focusable" placeholder={this.placeholder} ref={(el) => (this.input = el)} type={this.type} diff --git a/src/liquid/components/ld-input/test/__snapshots__/ld-input.spec.ts.snap b/src/liquid/components/ld-input/test/__snapshots__/ld-input.spec.ts.snap index c0aa62103f..86447e86f2 100644 --- a/src/liquid/components/ld-input/test/__snapshots__/ld-input.spec.ts.snap +++ b/src/liquid/components/ld-input/test/__snapshots__/ld-input.spec.ts.snap @@ -4,7 +4,7 @@ exports[`ld-input renders 1`] = ` - + @@ -14,7 +14,7 @@ exports[`ld-input renders as dark input with prop tone set to "dark" 1`] = ` - + @@ -22,7 +22,7 @@ exports[`ld-input renders as dark input with prop tone set to "dark" 1`] = ` exports[`ld-input renders type file (multiline) 1`] = ` - + @@ -32,7 +32,7 @@ exports[`ld-input renders type file 1`] = ` - + @@ -43,7 +43,7 @@ exports[`ld-input renders with both slots 1`] = ` - + @@ -59,7 +59,7 @@ exports[`ld-input renders with slot end 1`] = ` - + @@ -72,7 +72,7 @@ exports[`ld-input renders with slot start 1`] = ` - + @@ -85,7 +85,7 @@ exports[`ld-input renders with value 1`] = ` - + @@ -95,7 +95,7 @@ exports[`ld-input updates value prop on value change 1`] = ` - + diff --git a/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.tsx b/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.tsx index d1cd392af9..ca550f59de 100644 --- a/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.tsx +++ b/src/liquid/components/ld-select/ld-option-internal/ld-option-internal.tsx @@ -140,7 +140,7 @@ export class LdOptionInternal { onMouseOver={() => (this.hasHover = true)} onMouseOut={() => (this.hasHover = false)} tabindex="-1" - part="option" + part="option focusable" > {this.mode === 'checkbox' ? (
{ this.handleClearSingleClick.call( this, @@ -991,7 +991,7 @@ export class LdSelect { } onClick={this.handleClearClick.bind(this)} ref={(el) => (this.btnClearRef = el as HTMLButtonElement)} - part="btn-clear" + part="btn-clear focusable" > (this.btnRef = el as HTMLButtonElement)} role="tab" tabindex={this.selected ? undefined : '-1'} diff --git a/src/liquid/components/ld-tabs/ld-tab/readme.md b/src/liquid/components/ld-tabs/ld-tab/readme.md index b4f39be832..0745e6e1c7 100644 --- a/src/liquid/components/ld-tabs/ld-tab/readme.md +++ b/src/liquid/components/ld-tabs/ld-tab/readme.md @@ -65,6 +65,7 @@ Type: `Promise` | ---------------- | ------------------------- | | `"button"` | Actual button element | | `"content"` | Element wrapping the slot | +| `"focusable"` | | | `"spacer"` | Both spacer elements | | `"spacer-left"` | Left spacer element | | `"spacer-right"` | Right spacer element | diff --git a/src/liquid/components/ld-tabs/ld-tablist/test/__snapshots__/ld-tablist.spec.ts.snap b/src/liquid/components/ld-tabs/ld-tablist/test/__snapshots__/ld-tablist.spec.ts.snap index cd9030c051..eb65bd8669 100644 --- a/src/liquid/components/ld-tabs/ld-tablist/test/__snapshots__/ld-tablist.spec.ts.snap +++ b/src/liquid/components/ld-tabs/ld-tablist/test/__snapshots__/ld-tablist.spec.ts.snap @@ -27,7 +27,7 @@ exports[`ld-tablist modifiers mode 1`] = ` - @@ -39,7 +39,7 @@ exports[`ld-tablist modifiers mode 1`] = ` -