Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup panics and properly redirect to slack server #141

Merged
merged 4 commits into from Jan 10, 2020

Conversation

@adamdecaf
Copy link
Contributor

adamdecaf commented Jan 9, 2020

I ran into some "cannot read property" from signing up with a slack invite. This change works for me to redirect and not panic on slack.moov.io.

adamdecaf added a commit to moov-io/infra that referenced this pull request Jan 9, 2020
@adamdecaf adamdecaf force-pushed the moov-io:fixup-panics branch from 032f92e to 35171bd Jan 9, 2020
}
return res.status(200).json({ msg: 'WOOT. Check your email!' });
return res.status(200).json({
msg: 'WOOT. Check your email!',

This comment has been minimized.

Copy link
@wadearnold

wadearnold Jan 9, 2020

Without a woot nobody is happy.

emedvedev added 2 commits Jan 10, 2020
@emedvedev emedvedev dismissed stale reviews from wadearnold and themself via 112881c Jan 10, 2020
@emedvedev emedvedev merged commit c5d494b into emedvedev:master Jan 10, 2020
4 checks passed
4 checks passed
Node 10
Details
Node 12
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
now Deployment has completed
Details
@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Jan 10, 2020

Thanks! Fixed the tests and merged :)

@adamdecaf adamdecaf deleted the moov-io:fixup-panics branch Jan 10, 2020
@adamdecaf

This comment has been minimized.

Copy link
Contributor Author

adamdecaf commented Jan 10, 2020

Awesome! Thanks for the quick merge. What's the process for a new container release? I've built and run an image myself with this which works for now.

@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Jan 11, 2020

The containers are built automatically: https://hub.docker.com/repository/docker/emedvedev/slackin-extended. You can just grab the latest master or any active branch from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.