Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce stylelint and autoprefixer #63

Merged
merged 5 commits into from Oct 28, 2019
Merged

Introduce stylelint and autoprefixer #63

merged 5 commits into from Oct 28, 2019

Conversation

@XhmikosR
Copy link
Contributor

XhmikosR commented Oct 24, 2019

No description provided.

@XhmikosR XhmikosR force-pushed the XhmikosR:css branch from 7352e72 to 38bc72f Oct 24, 2019
@@ -0,0 +1,13 @@
# https://github.com/browserslist/browserslist#readme

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Oct 24, 2019

Author Contributor

I used what we use in Bootstrap v4, but we can adapt it later

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Oct 24, 2019

This adds a lot of devDependencies, but for production it should be almost the same.

@XhmikosR XhmikosR force-pushed the XhmikosR:css branch 2 times, most recently from 1f233e8 to 81bbcc2 Oct 25, 2019
@@ -16,6 +16,7 @@
],
"dependencies": {
"args": "^5.0.1",
"autoprefixer": "^9.7.0",

This comment has been minimized.

Copy link
@emedvedev

emedvedev Oct 25, 2019

Owner

Shouldn't we rather move this (and other modules that are only needed during the build) to devDependencies as well?

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Oct 26, 2019

Author Contributor

Yeah, but this is simpler for deployments.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Oct 26, 2019

Author Contributor

We can revert to the previous behavior and move the devDeps. But if one has set production on Heroku, we need that extra step to explicitly install the devDeps.

@XhmikosR XhmikosR force-pushed the XhmikosR:css branch 2 times, most recently from 110c6dc to 6d01739 Oct 26, 2019
@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Oct 27, 2019

When you have the time, please resubmit the PR to trigger the Now deployment :)

@XhmikosR XhmikosR force-pushed the XhmikosR:css branch from 6d01739 to 42fe7df Oct 28, 2019
@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Oct 28, 2019

I'd say better protect the branches with CI too and see what's needed for Now to deploy for outsiders' PRs :)

@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Oct 28, 2019

@XhmikosR Now won't deploy outsiders' PRs without authorization, because secrets are used.

@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Oct 28, 2019

No option to force it to deploy with secrets as far as I can tell :( Which would normally make sense, except in our case the secrets aren't that important.

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Oct 28, 2019

@emedvedev there's definitely an option :P In the same place you set Now and lgtm to be required.

And how is PR deployments to work for outsiders? Manually?

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Oct 28, 2019

BTW the deployment errors out with 502 in this PR.

@emedvedev

This comment has been minimized.

XhmikosR added 5 commits Oct 24, 2019
It will run after Sass. Also skip iframe-button.css.
This is done in the test script already
@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Oct 28, 2019

Seems to be working well ❤️

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Oct 28, 2019

Just make sure you enable Node 10 and Node 12 to pass :)

@emedvedev emedvedev merged commit eb20fa0 into emedvedev:master Oct 28, 2019
4 checks passed
4 checks passed
Node 10
Details
Node 12
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
now Deployment has completed
Details
@XhmikosR XhmikosR deleted the XhmikosR:css branch Oct 28, 2019
@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

XhmikosR commented Oct 28, 2019

You shouldn't have squashed this :/

@emedvedev

This comment has been minimized.

Copy link
Owner

emedvedev commented Oct 28, 2019

Oops, sorry! I'm a bit overwhelmed with the amount of changes, so some things slip my mind :) Gotta be more careful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.