Don't send CAPABILITY statement unsolicited after starting TLS connections. #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting TLS connections. Clients should be re-requesting it as per https://tools.ietf.org/html/rfc3501#section-6.2.1 This fixes k9 mail for Android.
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
- Coverage 72.99% 72.98% -0.01%
==========================================
Files 32 32
Lines 3462 3461 -1
==========================================
- Hits 2527 2526 -1
Misses 642 642
Partials 293 293
Continue to review full report at Codecov.
|
emersion
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients should be re-requesting it as per https://tools.ietf.org/html/rfc3501#section-6.2.1.
This fixes k9 mail for Android, which gets confused by receiving an unsolicited command straight after the TLS connection has been made.