micalg: convert raw micalg to lowercase for map lookup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some mail clients send micalg values in uppercase. The current implementation doesn't allow for anything other than lowercase. The referenced table (RFC4880 9.4) lists the algorithms in uppercase, so it's reasonable that a client would send a micalg in something other than lowercase. This patch converts the raw micalg to lowercase, and modifies a test case to have an uppercase micalg. Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mail clients send micalg values in uppercase. The current
implementation doesn't allow for anything other than lowercase.
The referenced table (RFC4880 9.4) lists the algorithms in uppercase, so
it's reasonable that a client would send a micalg in something other
than lowercase.
This patch converts the raw micalg to lowercase, and modifies a test
case to have an uppercase micalg.
Signed-off-by: Tim Culverhouse tim@timculverhouse.com