New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:npm-deps support #463

Closed
ar7hur opened this Issue May 16, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@ar7hur

ar7hur commented May 16, 2017

ClojureScript 1.9.518 introduced a :npm-deps build option to easily use Node.js libraries (more info), but cljsbuild doesn't recognize the key:

Found unrecognized key :npm-deps at path (:cljsbuild :builds 0 :compiler)
Must be one of: :infer-externs, :output-dir, :closure-warnings, :closure-defines, :static-fns, :dump-core, :externs, :ups-libs, :optimize-constants, :cache-analysis, :modules, :elide-asserts, :language-out, :optimizations, :recompile-dependents, :source-map-path, :closure-extra-annotations, :ups-foreign-libs, :parallel-build, :verbose, :warnings, :preloads, :source-map-inline, :anon-fn-naming-policy, :output-to, :source-map-timestamp, :preamble, :asset-path, :print-input-delimiter, :output-wrapper, :ups-externs, :hashbang, :source-map, :watch-fn, :foreign-libs, :libs, :target, :pseudo-names, :devcards, :external-config, :compiler-stats, :main, :pretty-print, :closure-output-charset, :language-in, :warning-handlers or :emit-constants

/.../project.clj:35:27
  34                 :compiler {:main axe.core
  35                            :npm-deps {:left-pad "1.1.3"}
                                ^---  The key :npm-deps is unrecognized
  36                            :asset-path "js/compiled/out"
  37                            :output-to "resources/public/js/compiled/axe.js"
  38                            :output-dir "resources/public/js/compiled/out"
  39                            :source-map-timestamp true
@mneise

This comment has been minimized.

Collaborator

mneise commented May 16, 2017

Adding a new compiler option to ClojureScript usually doesn't require a change in cljsbuild. It's likely that there is a typo or something else doesn't fit. Would you mind posting your whole project.clj?

@danielcompton

This comment has been minimized.

Contributor

danielcompton commented May 16, 2017

That error looks like a Figwheel error, not a cljsbuild one. What are you running to produce that error?

@ar7hur

This comment has been minimized.

ar7hur commented May 22, 2017

@danielcompton you're absolutely right, this is generated by Figwheel. I'll move the issue over there. Thanks and sorry for the inconvenience!

@ar7hur ar7hur closed this May 22, 2017

@ar7hur

This comment has been minimized.

ar7hur commented May 22, 2017

Actually, it was just fixed in Figwheel: bhauman/lein-figwheel@5b809b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment