New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple source paths #173

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@thheller
Copy link
Contributor

thheller commented Jan 17, 2013

Adds support for a :source-paths [path1 path2 ...] option for a build, overriding the standard :source-path attribute.

This works but should probably breaks the tests. I didnt run them cause I'm not familiar with midje and your whole testing setup. Basically the only thing changed is the cljsbuild.compiler/run-compiler function in that it expects a seq of paths instead of a single path.

There is one part of that function I did not look into yet, since I didnt fully get what its intention was. See FIXME comment.

It does not require any changes to the clojurescript compiler itself.

Probably resolves #157 and #108

Thomas Heller
add support for multiple source paths
Just add a :source-paths [path1 path2] vector to your build
just like standard clj :source-paths
@thheller

This comment has been minimized.

Copy link
Contributor Author

thheller commented Jan 18, 2013

I'd love to help this along but unfortunately just about everything barfs at me. ./bin/test-install.sh fails cause realpath does not exist (I'm on OSX) and while I can easily remove that lein midje still fails cause 'midje' is not a task.. Now I assume this has the be some Leiningen version thing (I'm using 2.0.0-RC2) but even if I upgrade the project.clj to {:plugins [[lein-midje "2.0.0-SNAPSHOT"]]} and then "fix" the tests and run lein midje I manage to get it into an infinite loop.

Since I'm not familiar with midje and dont want to force new versions of either lein or midje on you I'm simply at a loss at how to get this all running. The basic assumption of the changes is that all functions previously accepting a cljs-path now accept a vector of cljs-paths. This of course violates what midje expects since it has different assumptions. But I dont know midje well enough to change that, sorry.

I can say that have installed this modified version locally and use it in my project with multiple source-paths, everything seems to work as intended.

@emezeske

This comment has been minimized.

Copy link
Owner

emezeske commented Jan 21, 2013

I merged this and fixed all of the tests it broke (among other things). It will go out in the 0.3.0 release. Thanks again.

@thheller

This comment has been minimized.

Copy link
Contributor Author

thheller commented Jan 21, 2013

Awesome, thanks!

@thheller thheller referenced this pull request Jun 17, 2017

Closed

Documentation?! #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment