Final version#8
Open
sboulema wants to merge 6 commits into
Open
Conversation
added 4 commits
December 14, 2012 12:06
- Failed lines are retried 3 times - Lines are checked for correct number of fields - Logging is moved from console to log4net file - Exceptions are catched in main program and also written to log4net
Owner
|
Awesome good work, thanks for your PR. I'll review it and merge it later! |
added 2 commits
January 16, 2013 17:16
Owner
|
Hey thanks for updating your code, it didnt build at first! |
Owner
|
Hi! I've tested your code, looks good but i noticed the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for being a day late!